This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Legalize FDIV64
ClosedPublic

Authored by kerbowa on Nov 18 2019, 9:27 AM.

Event Timeline

kerbowa created this revision.Nov 18 2019, 9:27 AM
arsenm added inline comments.Nov 18 2019, 7:44 PM
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
1890

All these auto substitutions are unrelated

2125–2133

The ugliness of casting to a vector and extracting the elements isn't necessary. This isn't the canonical way to handle this in GlobalISel. You can use G_UNMERGE_VALUES to 2 S32 pieces more naturally

kerbowa updated this revision to Diff 230126.Nov 19 2019, 12:28 PM

Use G_UNMERGE_VALUES.

kerbowa updated this revision to Diff 230127.Nov 19 2019, 12:33 PM

Remove unrelated change to Flags type.

Harbormaster completed remote builds in B41195: Diff 230127.
kerbowa marked 2 inline comments as done.Nov 19 2019, 12:34 PM
arsenm accepted this revision.Nov 19 2019, 6:59 PM

LGTM, but it looks like none of these tests have the preserved flags?

This revision is now accepted and ready to land.Nov 19 2019, 6:59 PM
This revision was automatically updated to reflect the committed changes.