This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++
AbandonedPublic

Authored by CaseyCarter on Nov 11 2019, 1:20 PM.

Details

Summary

valarray:min and valarray::max have preconditions that require the valarray to be non-empty, so these calls are inherently non-portable.

Diff Detail

Event Timeline

CaseyCarter created this revision.Nov 11 2019, 1:20 PM
ldionne accepted this revision.Jan 29 2020, 4:54 PM

You can go ahead and commit this.

test/std/numerics/numarray/template.valarray/valarray.members/min.pass.cpp
29

typo: size() > 0

This revision is now accepted and ready to land.Jan 29 2020, 4:54 PM
CaseyCarter abandoned this revision.Jan 29 2020, 5:13 PM
CaseyCarter added a subscriber: STL_MSFT.

@STL_MSFT seems to have already fixed this by removing the problem test cases in bf7dc572f199007cbe042d5ea41bcf873dcedd8f. I'll simply abandon this change.