Page MenuHomePhabricator

[ConstExprPreter] Removed the flag forcing the use of the interpreter
ClosedPublic

Authored by nand on Nov 11 2019, 3:17 AM.

Details

Summary

Removed the -fforce-experimental-new-constant-interpreter flag, leaving
only the -fexperimental-new-constant-interpreter one. The interpreter
now always emits an error on an unsupported feature.

Allowing the interpreter to bail out would require a mapping from APValue to
interpreter memory, which will not be necessary in the final version. It is
more sensible to always emit an error if the interpreter fails.

Diff Detail

Event Timeline

nand created this revision.Nov 11 2019, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2019, 3:17 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nand edited the summary of this revision. (Show Details)Nov 11 2019, 3:17 AM
This revision is now accepted and ready to land.Fri, Nov 22, 12:27 PM
This revision was automatically updated to reflect the committed changes.