Page MenuHomePhabricator

clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight
ClosedPublic

Authored by dexonsmith on Nov 10 2019, 11:43 AM.

Details

Summary

As part of an audit of whether all errors are being reported from the
ASTReader, delay err_module_file_conflict if a diagnostic is already in
flight when it is hit. This required plumbing an extra argument through
the delayed diagnostic mechanics in DiagnosticsEngine.

Diff Detail

Event Timeline

dexonsmith created this revision.Nov 10 2019, 11:43 AM

Updated header docs for the new delayed diagnostic parameter.

aprantl accepted this revision.Nov 11 2019, 2:26 PM
This revision is now accepted and ready to land.Nov 11 2019, 2:26 PM