Page MenuHomePhabricator

clang/Modules: Add missing diagnostics for malformed AST files
ClosedPublic

Authored by dexonsmith on Nov 10 2019, 11:42 AM.

Details

Summary

These were found via an audit. In the case of ParseLineTable this is
actually dead code, since parsing the line table always succeeds, but
it's prudent to be defensive since it's possible an assertion there
could be converted to a true return in the future.

Diff Detail

Event Timeline

dexonsmith created this revision.Nov 10 2019, 11:42 AM
aprantl accepted this revision.Nov 11 2019, 2:25 PM
aprantl added inline comments.
clang/lib/Serialization/ASTReader.cpp
3412

Note for self, this is not an llvm::Error object but ASTReader::Error().

This revision is now accepted and ready to land.Nov 11 2019, 2:25 PM