This is an archive of the discontinued LLVM Phabricator instance.

[Support] fix mingw-w64 build
ClosedPublic

Authored by lh123 on Nov 5 2019, 10:10 PM.

Details

Summary

Mingw-w64 does not define _beginthreadex_proc_type, so we should replace it with unsigned (__stdcall *ThreadFunc)(void *).
fix https://github.com/clangd/clangd/issues/188

Diff Detail

Event Timeline

lh123 created this revision.Nov 5 2019, 10:10 PM
lh123 edited the summary of this revision. (Show Details)Nov 5 2019, 10:14 PM

FWIW, the latest git version of mingw-w64 has this typedef (since llvm started using it here a couple weeks ago), but being able to compile with older versions might be good of course,

lh123 added a comment.Nov 5 2019, 11:11 PM

FWIW, the latest git version of mingw-w64 has this typedef (since llvm started using it here a couple weeks ago), but being able to compile with older versions might be good of course,

Yes, introduced by rGa9c3c176ad74

This revision is now accepted and ready to land.Nov 6 2019, 12:53 AM
lh123 added a comment.EditedNov 6 2019, 3:31 AM

LGTM

I don't have commit access, can you commit it for me?

This revision was automatically updated to reflect the committed changes.