Page MenuHomePhabricator

lh123 (liu hui)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2019, 1:05 AM (124 w, 2 d)

Recent Activity

Thu, Dec 2

lh123 updated the diff for D114665: [clangd] Make a.k.a printing configurable..

rebase to head.

Thu, Dec 2, 10:09 PM · Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

rebase to head.

Thu, Dec 2, 10:08 PM · Restricted Project, Restricted Project
lh123 committed rG7bb785cc339b: [clangd] Show parameters for construct. (authored by lh123).
[clangd] Show parameters for construct.
Thu, Dec 2, 9:21 PM
lh123 closed D114621: [clangd] Show parameters for construct..
Thu, Dec 2, 9:21 PM · Restricted Project
lh123 updated the diff for D114621: [clangd] Show parameters for construct..

address comment.

Thu, Dec 2, 8:36 PM · Restricted Project

Sat, Nov 27

lh123 updated the diff for D114665: [clangd] Make a.k.a printing configurable..

fix testcase.

Sat, Nov 27, 5:04 AM · Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

format again.

Sat, Nov 27, 4:09 AM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

format code.

Sat, Nov 27, 4:08 AM · Restricted Project, Restricted Project
lh123 requested review of D114665: [clangd] Make a.k.a printing configurable..
Sat, Nov 27, 4:03 AM · Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

address comment.

Sat, Nov 27, 2:58 AM · Restricted Project, Restricted Project

Fri, Nov 26

lh123 added inline comments to D114621: [clangd] Show parameters for construct..
Fri, Nov 26, 11:35 PM · Restricted Project
lh123 updated the diff for D114621: [clangd] Show parameters for construct..

address comment.

Fri, Nov 26, 11:31 PM · Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.
Fri, Nov 26, 2:52 AM · Restricted Project, Restricted Project
lh123 changed the repository for D114522: [clangd] Add desugared type to hover from rZORG LLVM Github Zorg to rG LLVM Github Monorepo.
Fri, Nov 26, 2:50 AM · Restricted Project, Restricted Project
lh123 requested review of D114621: [clangd] Show parameters for construct..
Fri, Nov 26, 2:49 AM · Restricted Project
lh123 added inline comments to D114522: [clangd] Add desugared type to hover.
Fri, Nov 26, 1:25 AM · Restricted Project, Restricted Project
lh123 added inline comments to D114522: [clangd] Add desugared type to hover.
Fri, Nov 26, 1:18 AM · Restricted Project, Restricted Project
lh123 added inline comments to D114522: [clangd] Add desugared type to hover.
Fri, Nov 26, 1:13 AM · Restricted Project, Restricted Project
lh123 added inline comments to D114522: [clangd] Add desugared type to hover.
Fri, Nov 26, 12:31 AM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

Move some desugared type to Definition.

Fri, Nov 26, 12:28 AM · Restricted Project, Restricted Project

Thu, Nov 25

lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

rename TTP to TAT.

Thu, Nov 25, 11:29 PM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

handle TypeAliasTemplateDecl.

Thu, Nov 25, 11:24 PM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.
  1. rename CanType to DesugaredTy.
  2. fix some bug in compare PrintedType.
Thu, Nov 25, 10:25 PM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

fix some bug.

Thu, Nov 25, 10:05 PM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

address comment.

Thu, Nov 25, 9:51 PM · Restricted Project, Restricted Project

Wed, Nov 24

lh123 updated the summary of D114522: [clangd] Add desugared type to hover.
Wed, Nov 24, 7:28 PM · Restricted Project, Restricted Project
lh123 added a comment to D114522: [clangd] Add desugared type to hover.

Related discussions: D72498

Wed, Nov 24, 7:27 PM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

format code and add testcase for template.

Wed, Nov 24, 7:20 PM · Restricted Project, Restricted Project
lh123 updated the summary of D114522: [clangd] Add desugared type to hover.
Wed, Nov 24, 3:33 AM · Restricted Project, Restricted Project
lh123 updated the diff for D114522: [clangd] Add desugared type to hover.

add testcase

Wed, Nov 24, 3:32 AM · Restricted Project, Restricted Project
lh123 requested review of D114522: [clangd] Add desugared type to hover.
Wed, Nov 24, 3:21 AM · Restricted Project, Restricted Project

Jun 30 2020

lh123 committed rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123).
[CodeComplete] Add code completion after function equals
Jun 30 2020, 10:11 PM
lh123 closed D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..
Jun 30 2020, 10:11 PM · Restricted Project
lh123 added a comment to D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

Jun 30 2020, 10:11 PM · Restricted Project
lh123 updated the diff for D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..

Add the missing operator!=.

Jun 30 2020, 8:39 AM · Restricted Project
lh123 updated the diff for D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..

Address comments.

Jun 30 2020, 8:39 AM · Restricted Project
lh123 committed rG84ced55d9b7b: [clangd] Remove redundant `findRefs` calls. NFC. (authored by lh123).
[clangd] Remove redundant `findRefs` calls. NFC.
Jun 30 2020, 3:14 AM
lh123 closed D82714: [clangd] Remove redundant `findRefs` calls. NFC..
Jun 30 2020, 3:14 AM · Restricted Project

Jun 28 2020

lh123 updated the diff for D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..

Rebase

Jun 28 2020, 8:39 AM · Restricted Project
lh123 added a reviewer for D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.: sammccall.
Jun 28 2020, 8:39 AM · Restricted Project
lh123 updated the diff for D82714: [clangd] Remove redundant `findRefs` calls. NFC..

Rebase to head.

Jun 28 2020, 6:01 AM · Restricted Project
lh123 created D82714: [clangd] Remove redundant `findRefs` calls. NFC..
Jun 28 2020, 6:01 AM · Restricted Project
lh123 updated the diff for D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..

Rebase to head.

Jun 28 2020, 5:29 AM · Restricted Project

Jun 27 2020

lh123 added a reverting change for rGc19e82c6b38b: [Docs] Fix typo and test git commit access. NFC.: rG43e3c39327f9: Revert "[Docs] Fix typo and test git commit access. NFC.".
Jun 27 2020, 3:55 AM
lh123 added inline comments to rGc19e82c6b38b: [Docs] Fix typo and test git commit access. NFC..
Jun 27 2020, 3:52 AM
lh123 added inline comments to rGc19e82c6b38b: [Docs] Fix typo and test git commit access. NFC..
Jun 27 2020, 3:40 AM

Jun 26 2020

lh123 committed rGc19e82c6b38b: [Docs] Fix typo and test git commit access. NFC. (authored by lh123).
[Docs] Fix typo and test git commit access. NFC.
Jun 26 2020, 11:25 PM
lh123 updated the diff for D82535: [CodeComplete] Add code completion for using alias..

Rebase to head.

Jun 26 2020, 2:40 AM · Restricted Project

Jun 25 2020

lh123 retitled D82548: [CodeComplete] Add code completion for `delete` and `default` specifier. from [CodeComplete] add code completion for `delete` and `default` specifier. to [CodeComplete] Add code completion for `delete` and `default` specifier..
Jun 25 2020, 7:27 AM · Restricted Project
lh123 created D82548: [CodeComplete] Add code completion for `delete` and `default` specifier..
Jun 25 2020, 7:25 AM · Restricted Project
lh123 updated the diff for D82535: [CodeComplete] Add code completion for using alias..

Address comment.

Jun 25 2020, 6:20 AM · Restricted Project
lh123 updated the diff for D82535: [CodeComplete] Add code completion for using alias..

format code.

Jun 25 2020, 3:36 AM · Restricted Project
lh123 created D82535: [CodeComplete] Add code completion for using alias..
Jun 25 2020, 3:04 AM · Restricted Project

Jun 24 2020

lh123 abandoned D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows.
Jun 24 2020, 10:47 AM · Restricted Project
lh123 updated the diff for D82373: [CodeComplete] Tweak code completion for `typename`..

Address comment.
I will add using $alias$ = $type$; in a separate patch.

Jun 24 2020, 9:42 AM · Restricted Project
lh123 added inline comments to D82373: [CodeComplete] Tweak code completion for `typename`..
Jun 24 2020, 8:38 AM · Restricted Project
lh123 added inline comments to D82373: [CodeComplete] Tweak code completion for `typename`..
Jun 24 2020, 8:36 AM · Restricted Project
lh123 retitled D82373: [CodeComplete] Tweak code completion for `typename`. from [CodeComplete] Tweak code completion for `typename` to [CodeComplete] Tweak code completion for `typename` and `using`..
Jun 24 2020, 6:27 AM · Restricted Project
lh123 added a comment to D82373: [CodeComplete] Tweak code completion for `typename`..

If this patch looks good, please land it for me.

Jun 24 2020, 5:54 AM · Restricted Project
lh123 updated the summary of D82373: [CodeComplete] Tweak code completion for `typename`..
Jun 24 2020, 5:54 AM · Restricted Project
lh123 updated the diff for D82373: [CodeComplete] Tweak code completion for `typename`..

address comment.
Also tweak code completion behavior for using.

Jun 24 2020, 5:54 AM · Restricted Project

Jun 23 2020

lh123 retitled D82373: [CodeComplete] Tweak code completion for `typename`. from [CodeComplete] Tweak code completion for "typename to [CodeComplete] Tweak code completion for `typename`.
Jun 23 2020, 5:49 AM · Restricted Project
lh123 created D82373: [CodeComplete] Tweak code completion for `typename`..
Jun 23 2020, 5:49 AM · Restricted Project

Jan 14 2020

lh123 added a comment to D72623: [clangd] Rearrange type, returntype and parameters in hover card.

I think the character "🡺" should be avoided, as it may not display properly in some environments.

Jan 14 2020, 3:30 AM · Restricted Project

Jan 13 2020

lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.
  • hover over the front , you'll see "instance-method frontstd::vector<int, class std::allocator<int> >::reference".
  • hover over the push_back, you'll see "std::vector<int, class std::allocator<int> >::value_type && __x".

These look terrible and are the great examples where showing canonical types results in better output than canonical types.
I wonder why we add std::vector<int, class std::allocator<int>>:: in the first place, I believe the standard library uses value_type in the declaration. Showing value_type is not great, but at least that doesn't uglify what was written in the code in the first place.
FWIW, I think the perfect output in those cases would be int (aka value_type)

Indeed. Another illustrative example, the return type of vector<int64_t>::at() - we'd probably want int64& here, rather than vector<...>::reference or unsigned long long/unsigned long depending on platform.

Jan 13 2020, 1:20 AM · Restricted Project

Jan 11 2020

lh123 added a comment to D72500: [clangd] Show hover info for expressions.

I think we should avoid triggering for literals. Maybe some exceptions, but a hover saying that 0 is an int with value 0 seems silly.

Jan 11 2020, 8:14 PM · Restricted Project
lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

Could it be the case that we want to show the canonical types (i.e. without all syntax sugar)?
Maybe we want both the normal type and the canonical type?

Jan 11 2020, 4:56 AM · Restricted Project

Jan 10 2020

lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

what do you think about unwrapping decltype only when it's a return value (optional: of a function whose leading return type is auto) to narrowly catch this idiom?

Jan 10 2020, 7:43 PM · Restricted Project
lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

I think i'm also comfortable with marking the linked bug as wontfix.

Jan 10 2020, 8:34 AM · Restricted Project

Dec 9 2019

lh123 added a comment to D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.

@sammccall Could you commit this, I don't have commit access.

Dec 9 2019, 1:35 AM · Restricted Project
lh123 updated the diff for D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.

Address comments.

Dec 9 2019, 1:35 AM · Restricted Project
lh123 updated the diff for D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.
Dec 9 2019, 1:35 AM · Restricted Project

Dec 8 2019

lh123 created D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.
Dec 8 2019, 1:31 AM · Restricted Project

Nov 29 2019

lh123 added a comment to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Thanks a lot for working on this patch, LGTM!

again please make sure the changes are clang-formatted.

I'm sure the code has been formatted.

Nov 29 2019, 2:57 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

fix typo:
"Could not convert UTF16 To UTF8" -> "Could not convert UTF16 to UTF8"

Nov 29 2019, 2:55 AM · Restricted Project, Restricted Project
lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 29 2019, 1:56 AM · Restricted Project, Restricted Project

Nov 28 2019

lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 28 2019, 4:14 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 3:06 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

address comments.

Nov 28 2019, 3:05 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:53 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

fixes no matching constructor for initialization of llvm::StringError.

Nov 28 2019, 2:29 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:18 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:06 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

fix bug.

Nov 28 2019, 12:56 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

Sorry, upload the wrong patch.

Nov 28 2019, 12:56 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 28 2019, 12:21 AM · Restricted Project, Restricted Project

Nov 27 2019

lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

address comments.

Nov 27 2019, 11:58 PM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 11:35 PM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 10:37 PM · Restricted Project, Restricted Project
lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 27 2019, 6:45 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 6:45 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

rebase

Nov 27 2019, 5:49 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 5:41 AM · Restricted Project, Restricted Project
lh123 set the repository for D70769: [Support] add vfs support for ExpandResponseFiles to rG LLVM Github Monorepo.
Nov 27 2019, 4:51 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

rebase to D70769

Nov 27 2019, 4:47 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments and delete unused code.

Nov 27 2019, 4:38 AM · Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

Address comments

Nov 27 2019, 4:29 AM · Restricted Project, Restricted Project
lh123 added a comment to D70769: [Support] add vfs support for ExpandResponseFiles.

Are there any instances where we DON'T want to get the real file system? If not, could the *llvm::vfs::getRealFileSystem() call be put inside cl::ExpandResponseFiles?

Nov 27 2019, 1:46 AM · Restricted Project, Restricted Project
lh123 created D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 27 2019, 12:32 AM · Restricted Project, Restricted Project

Nov 26 2019

lh123 added inline comments to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 5:19 AM · Restricted Project, Restricted Project