Page MenuHomePhabricator

lh123 (liu hui)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2019, 1:05 AM (37 w, 4 d)

Recent Activity

Jan 14 2020

lh123 added a comment to D72623: [clangd] Rearrange type, returntype and parameters in hover card.

I think the character "๐Ÿกบ" should be avoided, as it may not display properly in some environments.

Jan 14 2020, 3:30 AM ยท Restricted Project

Jan 13 2020

lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.
  • hover over the front , you'll see "instance-method front โ†’ std::vector<int, class std::allocator<int> >::reference".
  • hover over the push_back, you'll see "std::vector<int, class std::allocator<int> >::value_type && __x".

These look terrible and are the great examples where showing canonical types results in better output than canonical types.
I wonder why we add std::vector<int, class std::allocator<int>>:: in the first place, I believe the standard library uses value_type in the declaration. Showing value_type is not great, but at least that doesn't uglify what was written in the code in the first place.
FWIW, I think the perfect output in those cases would be int (aka value_type)

Indeed. Another illustrative example, the return type of vector<int64_t>::at() - we'd probably want int64& here, rather than vector<...>::reference or unsigned long long/unsigned long depending on platform.

Jan 13 2020, 1:20 AM ยท Restricted Project

Jan 11 2020

lh123 added a comment to D72500: [clangd] Show hover info for expressions.

I think we should avoid triggering for literals. Maybe some exceptions, but a hover saying that 0 is an int with value 0 seems silly.

Jan 11 2020, 8:14 PM ยท Restricted Project
lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

Could it be the case that we want to show the canonical types (i.e. without all syntax sugar)?
Maybe we want both the normal type and the canonical type?

Jan 11 2020, 4:56 AM ยท Restricted Project

Jan 10 2020

lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

what do you think about unwrapping decltype only when it's a return value (optional: of a function whose leading return type is auto) to narrowly catch this idiom?

Jan 10 2020, 7:43 PM ยท Restricted Project
lh123 added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

I think i'm also comfortable with marking the linked bug as wontfix.

Jan 10 2020, 8:34 AM ยท Restricted Project

Dec 9 2019

lh123 added a comment to D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.

@sammccall Could you commit this, I don't have commit access.

Dec 9 2019, 1:35 AM ยท Restricted Project
lh123 updated the diff for D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.

Address comments.

Dec 9 2019, 1:35 AM ยท Restricted Project
lh123 updated the diff for D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.
Dec 9 2019, 1:35 AM ยท Restricted Project

Dec 8 2019

lh123 created D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase.
Dec 8 2019, 1:31 AM ยท Restricted Project

Nov 29 2019

lh123 added a comment to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Thanks a lot for working on this patch, LGTM!

again please make sure the changes are clang-formatted.

I'm sure the code has been formatted.

Nov 29 2019, 2:57 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

fix typo:
"Could not convert UTF16 To UTF8" -> "Could not convert UTF16 to UTF8"

Nov 29 2019, 2:55 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 29 2019, 1:56 AM ยท Restricted Project, Restricted Project

Nov 28 2019

lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 28 2019, 4:14 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 3:06 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

address comments.

Nov 28 2019, 3:05 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:53 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

fixes no matching constructor for initialization of llvm::StringError.

Nov 28 2019, 2:29 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:18 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 28 2019, 2:06 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

fix bug.

Nov 28 2019, 12:56 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

Sorry, upload the wrong patch.

Nov 28 2019, 12:56 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 28 2019, 12:21 AM ยท Restricted Project, Restricted Project

Nov 27 2019

lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

address comments.

Nov 27 2019, 11:58 PM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 11:35 PM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 10:37 PM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 27 2019, 6:45 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 6:45 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

rebase

Nov 27 2019, 5:49 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments.

Nov 27 2019, 5:41 AM ยท Restricted Project, Restricted Project
lh123 set the repository for D70769: [Support] add vfs support for ExpandResponseFiles to rG LLVM Github Monorepo.
Nov 27 2019, 4:51 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

rebase to D70769

Nov 27 2019, 4:47 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

address comments and delete unused code.

Nov 27 2019, 4:38 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70769: [Support] add vfs support for ExpandResponseFiles.

Address comments

Nov 27 2019, 4:29 AM ยท Restricted Project, Restricted Project
lh123 added a parent revision for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json: D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 27 2019, 1:46 AM ยท Restricted Project, Restricted Project
lh123 added a child revision for D70769: [Support] add vfs support for ExpandResponseFiles: D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 27 2019, 1:46 AM ยท Restricted Project, Restricted Project
lh123 added a comment to D70769: [Support] add vfs support for ExpandResponseFiles.

Are there any instances where we DON'T want to get the real file system? If not, could the *llvm::vfs::getRealFileSystem() call be put inside cl::ExpandResponseFiles?

Nov 27 2019, 1:46 AM ยท Restricted Project, Restricted Project
lh123 created D70769: [Support] add vfs support for ExpandResponseFiles.
Nov 27 2019, 12:32 AM ยท Restricted Project, Restricted Project

Nov 26 2019

lh123 added inline comments to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 5:19 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 5:10 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

address comments

Nov 26 2019, 5:01 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 4:51 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 4:42 AM ยท Restricted Project, Restricted Project
lh123 updated the summary of D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 26 2019, 2:53 AM ยท Restricted Project, Restricted Project

Nov 23 2019

lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Expand response files before inferMissingCompileCommands and inferTargetAndDriverMode

Nov 23 2019, 2:40 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Address comment

Nov 23 2019, 12:05 AM ยท Restricted Project, Restricted Project

Nov 19 2019

lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

fixes some bug and add more test.

Nov 19 2019, 6:31 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

fix typo in function document.

Nov 19 2019, 4:17 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Address comment

Nov 19 2019, 4:05 AM ยท Restricted Project, Restricted Project

Nov 18 2019

lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Respect JSONCommandLineSyntax

Nov 18 2019, 5:10 AM ยท Restricted Project, Restricted Project
lh123 updated the summary of D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 18 2019, 4:34 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Move the implementation to JSONCompilationDatabase.

Nov 18 2019, 4:34 AM ยท Restricted Project, Restricted Project
lh123 added a comment to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

Thanks for taking a look into this, the rsp files issue has came up before in the past but there wasn't enough investment to implement it.

Haven't checked the implementation in detail yet, I believe the layering should be different;

This is a common problem for all of the clang-related tools, as they all share the same "compilation database" abstraction layer, therefore it would be better to implement this at that layer so that other tools (e.g, clang-tidy) can also benefit from this.
You can find the related code in clang/include/clang/Tooling/CompilationDatabase.h and clang/lib/Tooling/CompilationDatabase.cpp.

Also compilation databases has been historically neglecting Virtual File System abstractions, it is hard to change it now. But would be great if you could try to keep that in mind while performing reads.

So would you mind making such changes ?

Nov 18 2019, 4:08 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D70359: [clangd] Show values of more expressions on hover.
Nov 18 2019, 1:47 AM ยท Restricted Project
lh123 added inline comments to D70359: [clangd] Show values of more expressions on hover.
Nov 18 2019, 1:47 AM ยท Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

format patch

Nov 18 2019, 12:48 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.

update diff

Nov 18 2019, 12:45 AM ยท Restricted Project, Restricted Project

Nov 17 2019

lh123 added inline comments to D70359: [clangd] Show values of more expressions on hover.
Nov 17 2019, 12:18 AM ยท Restricted Project

Nov 14 2019

lh123 added a comment to D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 14 2019, 1:45 AM ยท Restricted Project, Restricted Project
lh123 added a reviewer for D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json: kadircet.
Nov 14 2019, 12:24 AM ยท Restricted Project, Restricted Project

Nov 13 2019

lh123 updated the summary of D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 13 2019, 11:11 PM ยท Restricted Project, Restricted Project
lh123 created D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json.
Nov 13 2019, 11:02 PM ยท Restricted Project, Restricted Project
lh123 retitled D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows from [JSONCompilationDatabase] Fix backslash escaping on Windows to [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows.
Nov 13 2019, 1:00 AM ยท Restricted Project
lh123 added inline comments to D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows.
Nov 13 2019, 1:00 AM ยท Restricted Project

Nov 12 2019

lh123 created D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows.
Nov 12 2019, 11:11 PM ยท Restricted Project

Nov 11 2019

lh123 added a comment to D69996: [clangd] Fixes colon escaping on Windows.

I believe this patch fixes the issue, but we need to update the file test/semantic-highlighting.test.ts), the test "Colorizer groups decorations correctly" is diverged from the actual code, although it is still passed (both string and vscode.Uri have the toString method unfortunately).

@lh123 do you mind doing that?

Nov 11 2019, 6:14 AM ยท Restricted Project, Restricted Project
lh123 created D70078: [clangd] fixes semantic highlighting test.
Nov 11 2019, 6:05 AM ยท Restricted Project, Restricted Project

Nov 8 2019

lh123 added a comment to D69996: [clangd] Fixes colon escaping on Windows.

Thanks for your reminder, I have sent an email to apply for commit access, but I don't know how long it will take.

Nov 8 2019, 6:53 AM ยท Restricted Project, Restricted Project
lh123 retitled D69996: [clangd] Fixes colon escaping on Windows from [clangd] Fixed colon escaping on Windows to [clangd] Fixes colon escaping on Windows.
Nov 8 2019, 6:34 AM ยท Restricted Project, Restricted Project
lh123 added inline comments to D69996: [clangd] Fixes colon escaping on Windows.
Nov 8 2019, 5:31 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D69996: [clangd] Fixes colon escaping on Windows.

address comment

Nov 8 2019, 5:28 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D69996: [clangd] Fixes colon escaping on Windows.
Nov 8 2019, 3:29 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D69996: [clangd] Fixes colon escaping on Windows.

Remove irrelevant files from the patch

Nov 8 2019, 2:52 AM ยท Restricted Project, Restricted Project
lh123 updated the diff for D69996: [clangd] Fixes colon escaping on Windows.

update diff

Nov 8 2019, 2:49 AM ยท Restricted Project, Restricted Project
lh123 planned changes to D69996: [clangd] Fixes colon escaping on Windows.

it will cause whitspace escaped problem.

Nov 8 2019, 2:13 AM ยท Restricted Project, Restricted Project
lh123 created D69996: [clangd] Fixes colon escaping on Windows.
Nov 8 2019, 2:01 AM ยท Restricted Project, Restricted Project

Nov 7 2019

lh123 added a comment to D69928: [clangd] Set RetainCommentsFromSystemHeaders to true.

LGTM, thanks!
Do you need someone to land this?

Nov 7 2019, 12:31 AM ยท Restricted Project, Restricted Project

Nov 6 2019

lh123 added a reviewer for D69928: [clangd] Set RetainCommentsFromSystemHeaders to true: kadircet.
Nov 6 2019, 8:50 PM ยท Restricted Project, Restricted Project
lh123 created D69928: [clangd] Set RetainCommentsFromSystemHeaders to true.
Nov 6 2019, 8:32 PM ยท Restricted Project, Restricted Project
lh123 added a comment to D69879: [Support] fix mingw-w64 build.

LGTM

Nov 6 2019, 3:35 AM ยท Restricted Project

Nov 5 2019

lh123 added a comment to D69879: [Support] fix mingw-w64 build.

FWIW, the latest git version of mingw-w64 has this typedef (since llvm started using it here a couple weeks ago), but being able to compile with older versions might be good of course,

Nov 5 2019, 11:19 PM ยท Restricted Project
lh123 created D69879: [Support] fix mingw-w64 build.
Nov 5 2019, 10:15 PM ยท Restricted Project
lh123 updated the summary of D69879: [Support] fix mingw-w64 build.
Nov 5 2019, 10:15 PM ยท Restricted Project

Jul 18 2019

lh123 added a comment to D64970: [clangd] Handle windows line endings in QueryDriver.

LGTM thanks!

Do you have commit access?

Jul 18 2019, 11:21 PM ยท Restricted Project, Restricted Project, Restricted Project
lh123 retitled D64970: [clangd] Handle windows line endings in QueryDriver from Handle windows line endings in QueryDriver to [clangd] Handle windows line endings in QueryDriver.
Jul 18 2019, 11:02 PM ยท Restricted Project, Restricted Project, Restricted Project
lh123 updated the diff for D64970: [clangd] Handle windows line endings in QueryDriver.

update diff context.

Jul 18 2019, 10:45 PM ยท Restricted Project, Restricted Project, Restricted Project
lh123 updated the diff for D64970: [clangd] Handle windows line endings in QueryDriver.

update test.

Jul 18 2019, 10:37 PM ยท Restricted Project, Restricted Project, Restricted Project
lh123 created D64970: [clangd] Handle windows line endings in QueryDriver.
Jul 18 2019, 10:21 PM ยท Restricted Project, Restricted Project, Restricted Project