Page MenuHomePhabricator

[MIPS GlobalISel] Improve reg bank handling in MipsInstructionSelector
ClosedPublic

Authored by Petar.Avramovic on Oct 31 2019, 8:18 AM.

Details

Summary

Introduce helper methods and refactor pieces of code related to
register banks in MipsInstructionSelector.
Add a few detailed asserts in order to get a better overview
of LLT, register bank combinations that are supported at the moment
and reduce need to look at other files.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2019, 8:18 AM
atanasyan accepted this revision.Nov 1 2019, 4:12 AM

LGTM with a nit

llvm/lib/Target/Mips/MipsInstructionSelector.cpp
243

We can delete this return and the empty line above. The next return does the task.

This revision is now accepted and ready to land.Nov 1 2019, 4:12 AM

Address review comments.

This revision was automatically updated to reflect the committed changes.