This is an archive of the discontinued LLVM Phabricator instance.

[update_cc_test_checks.py] Pass the builtin include dir to clang
ClosedPublic

Authored by arichardson on Oct 30 2019, 2:10 AM.

Details

Summary

This is required to update tests that make use of builtin headers. To fix
this use the same command expansion as lit does for %clang_cc1. I tested
this by updating clang/test/CodeGen/arm-mve-intrinsics/scalar-shifts.c.
%clang_cc1 will now expand to `clang -cc1 -internal-isystem
$LLVM_BUILD/lib/clang/$VERSION/include -nostdsysteminc`.

Diff Detail

Event Timeline

arichardson created this revision.Oct 30 2019, 2:10 AM

This makes sense, but can you add a comment in Phabricator, or if it is short, add it to the git description? It helps understanding for posterity.

This makes sense, but can you add a comment in Phabricator, or if it is short, add it to the git description? It helps understanding for posterity.

Sorry, I don't quite understand what you would like me to do. Should I add the comment from the python to the commit message?

Add an example expansion of %clang_cc1 to the description.

Improve commit message

arichardson edited the summary of this revision. (Show Details)Oct 31 2019, 4:43 AM
MaskRay accepted this revision.Oct 31 2019, 8:24 AM
This revision is now accepted and ready to land.Oct 31 2019, 8:24 AM
This revision was automatically updated to reflect the committed changes.