Details
Details
- Reviewers
 arsenm - Commits
 - rG2b88b344f24c: AMDGPU/GlobalISel: Legalize FDIV32
 
Diff Detail
Diff Detail
- Repository
 - rG LLVM Github Monorepo
 - Build Status
 Buildable 40217 Build 40313: arc lint + arc unit 
Event Timeline
| llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
|---|---|---|
| 1977 | You don't need to propagate the flags here. You should remove the argument and not bother setting it on the instructions. These don't actually do anything with FP values  | |
| 1993 | This is an immediate field. You shouldn't be materializing it in a register  | |
| 2006 | Ditto  | |
| llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
|---|---|---|
| 2001 | This is also an immediate field. You could alternatively use S_SETREG_B32 which does use the register  | |
You don't need to propagate the flags here. You should remove the argument and not bother setting it on the instructions. These don't actually do anything with FP values