Page MenuHomePhabricator

[scudo][standalone] Consolidate lists
ClosedPublic

Authored by cryptoad on Oct 28 2019, 8:54 AM.

Details

Summary

This is a clean patch using the last diff of D69265, but using git
instead of svn, since svn went ro and arc was making my life harded
than it needed to be.

I was going to introduce a couple more lists and realized that our
lists are currently a bit all over the place. While we have a singly
linked list type relatively well defined, we are using doubly linked
lists defined on the fly for the stats and for the secondary blocks.

This CL adds a doubly linked list object, reorganizing the singly list
one to extract as much of the common code as possible. We use this
new type in the stats and the secondary. We also reorganize the list
tests to benefit from this consolidation.

There are a few side effect changes such as using for iterator loops
that are, in my opinion, cleaner in a couple of places.

Diff Detail

Event Timeline

cryptoad created this revision.Oct 28 2019, 8:54 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 28 2019, 8:54 AM
Herald added subscribers: Restricted Project, jfb. · View Herald Transcript
hctim accepted this revision.Oct 28 2019, 9:01 AM

LGTM - review done in D69265

This revision is now accepted and ready to land.Oct 28 2019, 9:01 AM
This revision was automatically updated to reflect the committed changes.