This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] [Windows] Add a log message if EnumProcessModules fails
ClosedPublic

Authored by mstorsjo on Oct 28 2019, 4:27 AM.

Download Raw Diff

Details

Reviewers

rnk
EricWF
ldionne
mclow.lists

Commits

rG08c7ff99e138: [libunwind] [Windows] Add a log message if EnumProcessModules fails

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 28 2019, 4:27 AM

Herald added subscribers: dexonsmith, christof. · View Herald TranscriptOct 28 2019, 4:27 AM

lgtm

This revision is now accepted and ready to land.Oct 28 2019, 1:55 PM

LGTM.

Closed by commit rG08c7ff99e138: [libunwind] [Windows] Add a log message if EnumProcessModules fails (authored by mstorsjo). · Explain WhyOct 31 2019, 12:39 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2019, 12:39 AM

Revision Contents

Path

Size

libunwind/

src/

AddressSpace.hpp

6 lines

Diff 226638

libunwind/src/AddressSpace.hpp

Show First 20 Lines • Show All 427 Lines • ▼ Show 20 Lines	_LIBUNWIND_TRACE_UNWINDING("findUnwindSections: section %p length %p",
(void )info.arm_section, (void )info.arm_section_length);		(void )info.arm_section, (void )info.arm_section_length);
if (info.arm_section && info.arm_section_length)		if (info.arm_section && info.arm_section_length)
return true;		return true;
#elif defined(_LIBUNWIND_SUPPORT_DWARF_UNWIND) && defined(_WIN32)		#elif defined(_LIBUNWIND_SUPPORT_DWARF_UNWIND) && defined(_WIN32)
HMODULE mods[1024];		HMODULE mods[1024];
HANDLE process = GetCurrentProcess();		HANDLE process = GetCurrentProcess();
DWORD needed;		DWORD needed;

if (!EnumProcessModules(process, mods, sizeof(mods), &needed))		if (!EnumProcessModules(process, mods, sizeof(mods), &needed)) {
		DWORD err = GetLastError();
		_LIBUNWIND_TRACE_UNWINDING("findUnwindSections: EnumProcessModules failed, "
		"returned error %d", (int)err);
return false;		return false;
		}

for (unsigned i = 0; i < (needed / sizeof(HMODULE)); i++) {		for (unsigned i = 0; i < (needed / sizeof(HMODULE)); i++) {
PIMAGE_DOS_HEADER pidh = (PIMAGE_DOS_HEADER)mods[i];		PIMAGE_DOS_HEADER pidh = (PIMAGE_DOS_HEADER)mods[i];
PIMAGE_NT_HEADERS pinh = (PIMAGE_NT_HEADERS)((BYTE *)pidh + pidh->e_lfanew);		PIMAGE_NT_HEADERS pinh = (PIMAGE_NT_HEADERS)((BYTE *)pidh + pidh->e_lfanew);
PIMAGE_FILE_HEADER pifh = (PIMAGE_FILE_HEADER)&pinh->FileHeader;		PIMAGE_FILE_HEADER pifh = (PIMAGE_FILE_HEADER)&pinh->FileHeader;
PIMAGE_SECTION_HEADER pish = IMAGE_FIRST_SECTION(pinh);		PIMAGE_SECTION_HEADER pish = IMAGE_FIRST_SECTION(pinh);
bool found_obj = false;		bool found_obj = false;
bool found_hdr = false;		bool found_hdr = false;
▲ Show 20 Lines • Show All 182 Lines • Show Last 20 Lines