This is an archive of the discontinued LLVM Phabricator instance.

Differential D69410

[compiler-rt] cmake: add include include(BuiltinTests)
ClosedPublic

Authored by plotfi on Oct 24 2019, 2:49 PM.

Details

Reviewers
compnerd
beanz
smeenai
Commits
rGbc58e0279b75: [compiler-rt] cmake: add include(BuiltinTests) to CompilerRTDarwinUtils
Summary

In cmake, if TEST_COMPILE_ONLY is set compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake invokes try_compile_only() but try_compile_only() is defined in BuiltinTests.cmake and is not included in CompilerRTDarwinUtils.cmake. This patch simply includes it.

Committed in https://github.com/llvm/llvm-project/commit/bc58e0279b75402be1907b96fac89e12ed326590

Diff Detail

Event Timeline

plotfi created this revision.Oct 24 2019, 2:49 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 24 2019, 2:49 PM
Herald added subscribers: llvm-commits, Restricted Project, mgorny, dberris. · View Herald Transcript
smeenai accepted this revision.Oct 24 2019, 2:50 PM
smeenai added a subscriber: smeenai.

LGTM

This revision is now accepted and ready to land.Oct 24 2019, 2:50 PM
compnerd accepted this revision.Oct 24 2019, 2:50 PM
plotfi closed this revision.Oct 24 2019, 3:42 PM
plotfi edited the summary of this revision. (Show Details)Oct 24 2019, 3:45 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
1 line

Diff 226333

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

include(CMakeParseArguments) include(CMakeParseArguments)
include(CompilerRTUtils) include(CompilerRTUtils)
include(BuiltinTests)
set(CMAKE_LIPO "lipo" CACHE PATH "path to the lipo tool") set(CMAKE_LIPO "lipo" CACHE PATH "path to the lipo tool")