Page MenuHomePhabricator

[CMake] [WinMsvc] Look for includes and libs in ${MSVC_BASE}/atlmfc
ClosedPublic

Authored by mstorsjo on Oct 21 2019, 1:08 AM.

Details

Summary

This is necessary if building with the DIA SDK enabled.

This doesn't seem to add any warnings in case the atlmfc directory doesn't exist, so hopefully it should be safe to just add it like this.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 21 2019, 1:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2019, 1:09 AM
Herald added a subscriber: mgorny. · View Herald Transcript
smeenai accepted this revision.Oct 21 2019, 1:02 PM

LGTM. I'll trust that you're matching the order used by VSDevCmd :)

This revision is now accepted and ready to land.Oct 21 2019, 1:02 PM

LGTM. I'll trust that you're matching the order used by VSDevCmd :)

Good point, I'll check that, and adjust if necessary, before committing :-)

This revision was automatically updated to reflect the committed changes.