This is an archive of the discontinued LLVM Phabricator instance.

Differential D69195

[libcxx] Fix .gitignore to not exclude test directories
ClosedPublic

Authored by smeenai on Oct 18 2019, 2:12 PM.

Details

Reviewers
EricWF
ldionne
mclow.lists
Group Reviewers
Restricted Project
Commits
rG4e2679cd12e4: [libcxx] Fix .gitignore to not exclude test directories
Summary

We have several test directories whose names end in .spec. Ensure we
don't accidentally ignore them by removing a section of the .gitignore
that's irrelevant for libc++.

Diff Detail

Event Timeline

smeenai created this revision.Oct 18 2019, 2:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2019, 2:12 PM
Herald added subscribers: libcxx-commits, dexonsmith, christof. · View Herald Transcript
Harbormaster completed remote builds in B39807: Diff 225692.Oct 18 2019, 2:14 PM
ldionne added inline comments.Oct 18 2019, 2:16 PM
libcxx/.gitignore
24–25

Why don't we just remove this? I don't understand what it's useful for, as I don't understand the comment just above.

smeenai marked an inline comment as done.Oct 18 2019, 2:24 PM
smeenai added inline comments.
libcxx/.gitignore
24–25

This seems like it might have been taken from some generic .gitignore file? I'm happy to remove the PyInstaller bits entirely though if that doesn't seem like something that's relevant for libc++.

smeenai updated this revision to Diff 239766.Jan 22 2020, 7:04 PM
smeenai edited the summary of this revision. (Show Details)

Comments

Harbormaster completed remote builds in B44665: Diff 239766.Jan 22 2020, 7:04 PM
ldionne accepted this revision.Mar 25 2020, 8:58 AM
This revision is now accepted and ready to land.Mar 25 2020, 8:58 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 8:58 AM
This revision now requires review to proceed.Mar 25 2020, 8:58 AM
ldionne accepted this revision.Mar 25 2020, 8:59 AM
This revision is now accepted and ready to land.Mar 25 2020, 8:59 AM
Closed by commit rG4e2679cd12e4: [libcxx] Fix .gitignore to not exclude test directories (authored by smeenai). · Explain WhyMar 25 2020, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
6 lines

Diff 239766

libcxx/.gitignore

Show All 15 Lines
#lib/ # We actually have things checked in to lib/ #lib/ # We actually have things checked in to lib/
lib64/ lib64/
parts/ parts/
sdist/ sdist/
var/ var/
*.egg-info/ *.egg-info/
.installed.cfg .installed.cfg
*.egg *.egg
# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec
# Installer logs # Installer logs
ldionneUnsubmitted
Not Done
ReplyInline Actions

Why don't we just remove this? I don't understand what it's useful for, as I don't understand the comment just above.

ldionne: Why don't we just remove this? I don't understand what it's useful for, as I don't understand…
smeenaiAuthorUnsubmitted
Done
ReplyInline Actions

This seems like it might have been taken from some generic .gitignore file? I'm happy to remove the PyInstaller bits entirely though if that doesn't seem like something that's relevant for libc++.

smeenai: This seems like it might have been taken from some generic `.gitignore` file? I'm happy to…
pip-log.txt pip-log.txt
pip-delete-this-directory.txt pip-delete-this-directory.txt
# Unit test / coverage reports # Unit test / coverage reports
htmlcov/ htmlcov/
.tox/ .tox/
.coverage .coverage
.cache .cache
Show All 22 Lines