Page MenuHomePhabricator

[libcxx] Fix .gitignore to not exclude test directories
Needs ReviewPublic

Authored by smeenai on Oct 18 2019, 2:12 PM.

Details

Summary

We have several test directories whose names end in .spec. Ensure we
don't accidentally ignore them by removing a section of the .gitignore
that's irrelevant for libc++.

Event Timeline

smeenai created this revision.Oct 18 2019, 2:12 PM
ldionne added inline comments.Oct 18 2019, 2:16 PM
libcxx/.gitignore
24–25

Why don't we just remove this? I don't understand what it's useful for, as I don't understand the comment just above.

smeenai marked an inline comment as done.Oct 18 2019, 2:24 PM
smeenai added inline comments.
libcxx/.gitignore
24–25

This seems like it might have been taken from some generic .gitignore file? I'm happy to remove the PyInstaller bits entirely though if that doesn't seem like something that's relevant for libc++.

smeenai updated this revision to Diff 239766.Wed, Jan 22, 7:04 PM
smeenai edited the summary of this revision. (Show Details)

Comments