convert LLDBSwigPythonCallTypeScript to ArgInfo::max_positional_args

[lawrence_danna]

Summary

This patch converts another user of ArgInfo::count over to
use ArgInfo::max_positional_args instead. I also add a test
to make sure both documented signatures for python type formatters
work.

lldb/packages/Python/lldbsuite/test/commands/expression/formatters/TestFormatters.py

def test(self):
         # EXPR-TYPES-NEW-FOO-NEXT:     (baz) b = {
         # EXPR-TYPES-NEW-FOO-NEXT:       (int) h = 97
         # EXPR-TYPES-NEW-FOO-NEXT:       (int) k = 99
         # EXPR-TYPES-NEW-FOO-NEXT:     }
         # EXPR-TYPES-NEW-FOO-NEXT:     (baz &) b_ref = 0x
         # EXPR-TYPES-NEW-FOO-NEXT:   }
         # EXPR-TYPES-NEW-FOO-NEXT: }
 
+
+        self.runCmd("type summary add -F formatters.foo_SummaryProvider3 foo")
+        self.filecheck("expression foo1", __file__, '-check-prefix=EXPR-FOO1opts')
+        # EXPR-FOO1opts: (foo) $
+        # EXPR-FOO1opts-SAME: a = 12
+        # EXPR-FOO1opts-SAME: a_ptr = {{[0-9]+}} -> 13
+        # EXPR-FOO1opts-SAME: i = 24
+        # EXPR-FOO1opts-SAME: i_ptr = {{[0-9]+}} -> 25
+        # EXPR-FOO1opts-SAME: b_ref = {{[0-9]+}}
+        # EXPR-FOO1opts-SAME: h = 27
+        # EXPR-FOO1opts-SAME: k = 29
+        # EXPR-FOO1opts-SAME: WITH_OPTS
+
+        self.runCmd("type summary delete foo")
+
         self.runCmd("type summary add -F formatters.foo_SummaryProvider foo")
 
         self.expect("expression new int(12)",
                     substrs=['(int *) $', ' = 0x'])
 
         self.runCmd(
             "type summary add -s \"${var%pointer} -> ${*var%decimal}\" \"int *\"")
 

lldb/packages/Python/lldbsuite/test/commands/expression/formatters/formatters.py

+import lldb
+
 def foo_SummaryProvider(valobj, dict):
     a = valobj.GetChildMemberWithName('a')
     a_ptr = valobj.GetChildMemberWithName('a_ptr')
     bar = valobj.GetChildMemberWithName('b')
     i = bar.GetChildMemberWithName('i')
     i_ptr = bar.GetChildMemberWithName('i_ptr')
     b_ref = bar.GetChildMemberWithName('b_ref')
     b_ref_ptr = b_ref.AddressOf()
     b_ref = b_ref_ptr.Dereference()
     h = b_ref.GetChildMemberWithName('h')
     k = b_ref.GetChildMemberWithName('k')
     return 'a = ' + str(a.GetValueAsUnsigned(0)) + ', a_ptr = ' + \
         str(a_ptr.GetValueAsUnsigned(0)) + ' -> ' + str(a_ptr.Dereference().GetValueAsUnsigned(0)) + \
         ', i = ' + str(i.GetValueAsUnsigned(0)) + \
         ', i_ptr = ' + str(i_ptr.GetValueAsUnsigned(0)) + ' -> ' + str(i_ptr.Dereference().GetValueAsUnsigned(0)) + \
         ', b_ref = ' + str(b_ref.GetValueAsUnsigned(0)) + \
         ', h = ' + str(h.GetValueAsUnsigned(0)) + ' , k = ' + str(k.GetValueAsUnsigned(0))
+
+def foo_SummaryProvider3(valobj, dict, options):
+    if not isinstance(options, lldb.SBTypeSummaryOptions):
+        raise Exception()
+    return foo_SummaryProvider(valobj, dict) + ", WITH_OPTS"
 No newline at end of file

lldb/scripts/Python/python-wrapper.swig

if (!pfunc.IsAllocated())
         if (pyfunct_wrapper)
         {
             *pyfunct_wrapper = pfunc.get();
             Py_XINCREF(pfunc.get());
         }
     }
 
     PythonObject result;
-    auto argc = pfunc.GetNumArguments();
-    // if the third argument is supported, or varargs are allowed
+    auto argc = pfunc.GetArgInfo();
+    if (!argc) {
+        llvm::consumeError(argc.takeError());
+        return false;
+    }
+
     PythonObject value_arg(PyRefType::Owned, SBTypeToSWIGWrapper(sb_value));
     PythonObject options_arg(PyRefType::Owned, SBTypeToSWIGWrapper(sb_options));
-    if (argc.count == 3 || argc.has_varargs)
-        result = pfunc(value_arg,dict,options_arg);
-    else
+
+    if (argc.get().max_positional_args < 3)
         result = pfunc(value_arg,dict);
+    else
+        result = pfunc(value_arg,dict,options_arg);
 
     retval = result.Str().GetString().str();
 
     return true;
 }
 
 SWIGEXPORT void*
 LLDBSwigPythonCreateSyntheticProvider