[gicombiner] Add support for arbitrary match data being passed from match to apply
AcceptedPublic
Actions

Authored by dsanders on Oct 17 2019, 3:33 PM.

Details

Reviewers

volkan
bogner

Summary

This is used by the extending_loads combine to tell the apply step which
use is the preferred one to fold and the other uses should be re-written
to consume.

Depends on D69117

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 39756
Build 39798: arc lint + arc unit

Event Timeline

dsanders created this revision.Oct 17 2019, 3:33 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 3:33 PM

Herald added subscribers: Petar.Avramovic, hiraditya. · View Herald Transcript

Harbormaster completed remote builds in B39756: Diff 225539.Oct 17 2019, 3:34 PM

dsanders added a child revision: D69151: [gicombiner] Import tryCombineIndexedLoadStore().Oct 17 2019, 5:28 PM

LGTM.

llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-concat-vectors.mir
22	These changes doesn't look relevant, could you double check?

This revision is now accepted and ready to land.Fri, Nov 15, 10:49 AM

Revision Contents
Changeset List

			Path	Packages
M			llvm/include/llvm/Target/GlobalISel/Combine.td (18 lines)
M			llvm/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpp (20 lines)
M			llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-concat-vectors.mir (32 lines)
M			llvm/utils/TableGen/GICombinerEmitter.cpp (83 lines)

Commit	Tree	Parents	Author	Summary	Date
70c988a00764	4b246ee5616a	4b7dadd7355c	Daniel Sanders	[gicombiner] Add support for arbitrary match data being passed from match to… (Show More…)	Oct 7 2019, 2:27 PM

Status	Author	Revision
Needs Review	dsanders	D69152 [gicombiner] Add GIMatchTree and use it for the code generation
Accepted	dsanders	D69151 [gicombiner] Import tryCombineIndexedLoadStore()
Accepted	dsanders	D69147 [gicombiner] Add support for arbitrary match data being passed from match to apply
Accepted	dsanders	D69117 [gicombiner] Process the MatchDag such that every node is reachable from the roots
Accepted	dsanders	D69077 [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input