Page MenuHomePhabricator

[LegacyPassManager] Delete BasicBlockPass/Manager.
ClosedPublic

Authored by asbirlea on Oct 17 2019, 10:37 AM.

Details

Summary

Delete the BasicBlockPass and BasicBlockManager, all its dependencies and update documentation.
The BasicBlockManager was improperly tested and found to be potentially broken, and was deprecated as of rL373254.

In light of the switch to the new pass manager coming before the next release, this patch is a first cleanup of the LegacyPassManager.

Diff Detail

Event Timeline

asbirlea created this revision.Oct 17 2019, 10:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 10:37 AM

Generally very happy with this. Would like Eric to check this as well to think about the C API and other things that we maybe should be doing while unbuilding this....

Wow I thought we already deleted BBPass a while ago, good cleanup!

echristo accepted this revision.Mon, Oct 28, 6:23 PM

The straight removal and updates definitely make sense as-is. As far as I can tell the C API doesn't have support for BBP and we're fine deleting it even if so.

Things that should happen:

  • We should absolutely put this as part of the release notes for the next release.

I can't think of anything else we might be missing here. Might want to send a message to llvm-dev to let people know it's happened in the near term.

Thanks!

This revision is now accepted and ready to land.Mon, Oct 28, 6:23 PM
This revision was automatically updated to reflect the committed changes.