Page MenuHomePhabricator

[lldb] move more things from python to cmake
ClosedPublic

Authored by hhb on Oct 15 2019, 8:08 PM.

Diff Detail

Event Timeline

hhb created this revision.Oct 15 2019, 8:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 15 2019, 8:08 PM
davide added a subscriber: davide.Oct 15 2019, 8:28 PM

What are you trying to accomplish here?

I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

labath accepted this revision.Oct 16 2019, 3:35 AM
labath added a reviewer: JDevlieghere.
labath added a subscriber: JDevlieghere.

What are you trying to accomplish here?

I believe the goal is to delete the custom python script completely and rely on cmake to do this instead. Now that we no longer have two build systems to worry about, I think this is a very good idea and it simplifies the code a lot. I believe that at least @JDevlieghere was also in favour of this direction.

This revision is now accepted and ready to land.Oct 16 2019, 3:35 AM
hhb added a comment.Oct 16 2019, 9:44 AM

I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

Agreed. After I move all the things to cmake, it will be a good idea to refactor POST_BUILD to separate targets. And make sure all file dependencies are correct. For now I want to keep the same semantic.

What are you trying to accomplish here?

I believe the goal is to delete the custom python script completely and rely on cmake to do this instead. Now that we no longer have two build systems to worry about, I think this is a very good idea and it simplifies the code a lot. I believe that at least @JDevlieghere was also in favour of this direction.

Besides that, I want to make sure cross compiling is correct. In the old python script, we only detect the build platform, and make decision based on that. That's obviously wrong for cross compiling...

This revision was automatically updated to reflect the committed changes.