Page MenuHomePhabricator

[Alignment][NFC] Remove dependency on GlobalObject::setAlignment(unsigned)
ClosedPublic

Authored by gchatelet on Oct 14 2019, 8:02 AM.

Diff Detail

Event Timeline

gchatelet created this revision.Oct 14 2019, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2019, 8:02 AM
courbet accepted this revision.Oct 15 2019, 1:39 AM
courbet added inline comments.
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
4764

getValueOr() ? (here and below)

llvm/lib/CodeGen/GlobalMerge.cpp
465–466

Please avoid repeating Align (here and below).

This revision is now accepted and ready to land.Oct 15 2019, 1:39 AM
gchatelet updated this revision to Diff 224974.Oct 15 2019, 2:25 AM
gchatelet marked 3 inline comments as done.
  • Address comments, fix ValueTest and Polly
gchatelet added inline comments.Oct 15 2019, 2:27 AM
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
4764

Unfortunately this doesn't work: MaybeAlign is a llvm::Optional<Align> so getValueOr() only accepts Align values which can't be 0 by definition.
The code will clean itself with the transition of (Alloca|Load|Store)Inst to Align.

This revision was automatically updated to reflect the committed changes.