python path should be platform-dependent

[llunak]

Summary

Because one of the installed files is the _lldb.so symlink.

[mgorny]

No, it isn't. Some distros patch some Python versions for that but it's not a rule.

[llunak]

Updated misleading description.

[labath]

As @mgorny said, I'm afraid the solution is not going to be as simple as attaching LLVM_LIBDIR_SUFFIX to the lib path. There is some ongoing work to refactor/fix the way python paths are handled, but unfortunately I've lost track of what exactly is the state of it right now. @mgorny, @hhb, would it be correct to say that once your python changes land, the above use case should work?

[hhb]

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

[llunak]

In D68910#1709832, @hhb wrote:

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

With current master 'ninja install' at least proceeds without an error. But it still puts things in lib/ and given that one of the files is the _lldb.so symlink, I still think it should go to lib64/ (and that's indeed where the official openSUSE package puts it).

[llunak]

How about this one?

[hhb]

In D68910#1710009, @llunak wrote:

How about this one?

This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the implementation of get_python_lib() in openSUSE? Thanks.

[hhb]

Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import distutils.sysconfig
>>> print(distutils.sysconfig.get_python_lib(True, False, ''))
lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False, '/abc'))
/abc/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False))
/usr/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, ''))
lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, '/abc'))
/abc/lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False))
/usr/lib/python3.6/site-packages

This is interesting...

[hhb]

One additional statement in openSUSE comparing to standard python:

libdir = plat_specific and get_config_var("platlibdir") or "lib"

Hmmm basically what does platform dependent mean...

Anyway this change looks good to me.

[llunak]

In D68910#1710147, @hhb wrote:

This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the implementation of get_python_lib() in openSUSE? Thanks.

https://build.opensuse.org/package/show/devel:languages:python:Factory/python3-base is the sources of the package. F00102-lib64.patch is probably what you're interested in.

lldb/CMakeLists.txt

 
 if (WIN32)
   add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE)
 endif()
 
 if (NOT LLDB_DISABLE_PYTHON)
   execute_process(
     COMMAND ${PYTHON_EXECUTABLE}
-        -c "import distutils.sysconfig; print(distutils.sysconfig.get_python_lib(False, False, ''))"
+        -c "import distutils.sysconfig; print(distutils.sysconfig.get_python_lib(True, False, ''))"
     OUTPUT_VARIABLE LLDB_PYTHON_DEFAULT_RELATIVE_PATH
     OUTPUT_STRIP_TRAILING_WHITESPACE)
 
   file(TO_CMAKE_PATH ${LLDB_PYTHON_DEFAULT_RELATIVE_PATH} LLDB_PYTHON_DEFAULT_RELATIVE_PATH)
   set(LLDB_PYTHON_RELATIVE_PATH ${LLDB_PYTHON_DEFAULT_RELATIVE_PATH}
     CACHE STRING "Path where Python modules are installed, relative to install prefix")
 
   add_subdirectory(scripts)