Page MenuHomePhabricator

[libunwind] Refactor CMake flag checks to match libc++ and libc++abi
ClosedPublic

Authored by phosek on Oct 10 2019, 7:46 PM.

Details

Summary

libunwind was using its own set of macros/functions for flag checking
which was similar but different from libc++ and libc++abi. This made
it difficult to replicate the same checks across projects, in fact
there were some checks that appear to have been copy & pasted from
another project and that were broken in the standalone libunwind build.
This change refactors flag checks to match libc++ and libc++abi using
a copy of HandleLibunwindFlags.cmake which is derived from the versions
used by the other projects. This also paves a road to deduplicating and
unifying HandleLibunwindFlags.cmake, HandleLibcxxabiFlags.cmake and
HandleLibcxxFlags.cmake post monorepo switch.

Diff Detail

Event Timeline

phosek created this revision.Oct 10 2019, 7:46 PM
ldionne accepted this revision.Oct 11 2019, 11:00 AM
This revision is now accepted and ready to land.Oct 11 2019, 11:00 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2019, 3:29 PM