Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator

[jordan_rose]

Summary

The output directories for CMake's Xcode project generator are specific to the configuration, and so looking in CMAKE_LIBRARY_OUTPUT_DIRECTORY isn't going to work. Fortunately, CMake already provides generator expressions to find the output of a given target.

I call this the bare minimum because the built framework isn't going to respect the configuration; that is, I can't have both Debug and RelWithDebInfo variants of ClangdXPC.framework at the same time like I can with normal library or executable targets. To do that we'd have to put the framework in a configuration-specific output directory too…or use CMake's native support for frameworks instead.

[jordan_rose]

Committed in rCTE374494.

clang-tools-extra/clangd/xpc/cmake/modules/CreateClangdXPCFramework.cmake

macro(create_clangd_xpc_framework target name)
   add_custom_command(OUTPUT ${CLANGD_FRAMEWORK_LOCATION}
     # Copy the PLIST.
     COMMAND ${CMAKE_COMMAND} -E copy
       "${CLANGD_XPC_BINARY_DIR}/${name}.Info.plist"
       "${CLANGD_FRAMEWORK_OUT_LOCATION}/Resources/Info.plist"
 
     # Copy the framework binary.
     COMMAND ${CMAKE_COMMAND} -E copy
-       "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/lib${target}.dylib"
+       "$<TARGET_FILE:${target}>"
        "${CLANGD_FRAMEWORK_OUT_LOCATION}/${name}"
 
     # Copy the XPC Service PLIST.
     COMMAND ${CMAKE_COMMAND} -E copy
       "${CLANGD_XPC_BINARY_DIR}/${name}Service.Info.plist"
       "${CLANGD_XPC_SERVICE_OUT_LOCATION}/Info.plist"
 
     # Copy the Clangd binary.
     COMMAND ${CMAKE_COMMAND} -E copy
-      "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/clangd"
+      "$<TARGET_FILE:clangd>"
       "${CLANGD_XPC_SERVICE_OUT_LOCATION}/MacOS/clangd"
 
      COMMAND ${CMAKE_COMMAND} -E create_symlink "A"
      "${CLANGD_FRAMEWORK_LOCATION}/Versions/Current"
 
      COMMAND ${CMAKE_COMMAND} -E create_symlink
      "Versions/Current/Resources"
      "${CLANGD_FRAMEWORK_LOCATION}/Resources"