Page MenuHomePhabricator

Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator
ClosedPublic

Authored by jordan_rose on Thu, Oct 10, 5:55 PM.

Details

Summary

The output directories for CMake's Xcode project generator are specific to the configuration, and so looking in CMAKE_LIBRARY_OUTPUT_DIRECTORY isn't going to work. Fortunately, CMake already provides generator expressions to find the output of a given target.

I call this the bare minimum because the built framework isn't going to respect the configuration; that is, I can't have both Debug and RelWithDebInfo variants of ClangdXPC.framework at the same time like I can with normal library or executable targets. To do that we'd have to put the framework in a configuration-specific output directory too…or use CMake's native support for frameworks instead.

Diff Detail

Event Timeline

jordan_rose created this revision.Thu, Oct 10, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Oct 10, 5:55 PM
arphaman accepted this revision.Thu, Oct 10, 6:01 PM
This revision is now accepted and ready to land.Thu, Oct 10, 6:01 PM