This is an archive of the discontinued LLVM Phabricator instance.

Differential D68754

[sanitizers] Update linker scripts to avoid emutls issues.
Needs ReviewPublic

Authored by hctim on Oct 9 2019, 6:13 PM.

Details

Reviewers
pcc
eugenis
Summary

The linker script for ASan contains an entry for _sancov_*. Android TLS symbols are emulated, and so we end up with __sancov_lowest_stack actually ending up with a symbol name of __emutls_v.__sancov_lowest_stack. This symbol is then discarded, as the linker script doesn't consider prefixes.

This patch fixes the above issue, and ensure that any sanitizer build for Android will correctly export symbols, even if they're prefixed with emutls.

Diff Detail

Event Timeline

hctim created this revision.Oct 9 2019, 6:13 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 9 2019, 6:13 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B39280: Diff 224227.Oct 9 2019, 6:13 PM
hctim updated this revision to Diff 224230.Oct 9 2019, 6:34 PM
  • Add test for emutls.
Herald added a subscriber: srhines. · View Herald TranscriptOct 9 2019, 6:34 PM
hctim edited the summary of this revision. (Show Details)Oct 9 2019, 6:35 PM
hctim added reviewers: pcc, eugenis.
Harbormaster completed remote builds in B39282: Diff 224230.Oct 9 2019, 6:41 PM
eugenis added inline comments.Oct 14 2019, 1:41 PM
compiler-rt/lib/ubsan/ubsan.syms.extra
1

why is sancov not in this list?
It can be handled in gen_dynamic_list.py, same as __sanitizer.

Revision Contents

PathSize
compiler-rt/
lib/
asan/
8 lines
hwasan/
5 lines
msan/
5 lines
ubsan/
2 lines
ubsan_minimal/
2 lines

Diff 224227

compiler-rt/lib/asan/asan.syms.extra

__asan_* *__asan_*
__lsan_* *__lsan_*
__ubsan_* *__ubsan_*
__sancov_* *__sancov_*

compiler-rt/lib/hwasan/hwasan.syms.extra

__hwasan_* *__hwasan_*
__ubsan_* *__ubsan_*
*__sancov_*

compiler-rt/lib/msan/msan.syms.extra

__msan_* *__msan_*
__ubsan_* *__ubsan_*
*__sancov_*

compiler-rt/lib/ubsan/ubsan.syms.extra

__ubsan_* *__ubsan_*
eugenisUnsubmitted
Not Done
ReplyInline Actions

why is sancov not in this list?
It can be handled in gen_dynamic_list.py, same as __sanitizer.

eugenis: why is sancov not in this list? It can be handled in gen_dynamic_list.py, same as __sanitizer.

compiler-rt/lib/ubsan_minimal/ubsan.syms.extra

__ubsan_* *__ubsan_*