This is an archive of the discontinued LLVM Phabricator instance.

Differential D68610

[clang] enable_trivial_var_init_zero should not be Joined<>
ClosedPublic

Authored by vitalybuka on Oct 7 2019, 4:49 PM.

Details

Reviewers
rnk
jfb
Commits
rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<>
rC374113: [clang] enable_trivial_var_init_zero should not be Joined<>
rL374113: [clang] enable_trivial_var_init_zero should not be Joined<>

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 7 2019, 4:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 4:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka mentioned this in D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl.Oct 7 2019, 4:55 PM
Harbormaster completed remote builds in B39127: Diff 223698.Oct 7 2019, 10:06 PM
vitalybuka added a reviewer: jfb.Oct 8 2019, 10:02 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptOct 8 2019, 10:02 AM
rnk accepted this revision.Oct 8 2019, 1:26 PM

lgtm

This revision is now accepted and ready to land.Oct 8 2019, 1:26 PM
Closed by commit rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<> (authored by vitalybuka). · Explain WhyOct 8 2019, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
include/
clang/
Driver/
2 lines

Diff 223698

clang/include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,711 Lines • ▼ Show 20 Linesdef fstack_protector : Flag<["-"], "fstack-protector">, Group<f_Group>,
HelpText<"Enable stack protectors for some functions vulnerable to stack smashing. " HelpText<"Enable stack protectors for some functions vulnerable to stack smashing. "
"This uses a loose heuristic which considers functions vulnerable " "This uses a loose heuristic which considers functions vulnerable "
"if they contain a char (or 8bit integer) array or constant sized calls to " "if they contain a char (or 8bit integer) array or constant sized calls to "
"alloca, which are of greater size than ssp-buffer-size (default: 8 bytes). " "alloca, which are of greater size than ssp-buffer-size (default: 8 bytes). "
"All variable sized calls to alloca are considered vulnerable">; "All variable sized calls to alloca are considered vulnerable">;
def ftrivial_auto_var_init : Joined<["-"], "ftrivial-auto-var-init=">, Group<f_Group>, def ftrivial_auto_var_init : Joined<["-"], "ftrivial-auto-var-init=">, Group<f_Group>,
Flags<[CC1Option, CoreOption]>, HelpText<"Initialize trivial automatic stack variables: uninitialized (default)" Flags<[CC1Option, CoreOption]>, HelpText<"Initialize trivial automatic stack variables: uninitialized (default)"
" | pattern">, Values<"uninitialized,pattern">; " | pattern">, Values<"uninitialized,pattern">;
def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, def enable_trivial_var_init_zero : Flag<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">,
Flags<[CC1Option, CoreOption]>, Flags<[CC1Option, CoreOption]>,
HelpText<"Trivial automatic variable initialization to zero is only here for benchmarks, it'll eventually be removed, and I'm OK with that because I'm only using it to benchmark">; HelpText<"Trivial automatic variable initialization to zero is only here for benchmarks, it'll eventually be removed, and I'm OK with that because I'm only using it to benchmark">;
def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, Flags<[CoreOption]>, def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, Flags<[CoreOption]>,
HelpText<"Emit full debug info for all types used by the program">; HelpText<"Emit full debug info for all types used by the program">;
def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>, Flags<[CoreOption]>, def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>, Flags<[CoreOption]>,
HelpText<"Limit debug information produced to reduce size of debug binary">; HelpText<"Limit debug information produced to reduce size of debug binary">;
def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Flags<[CoreOption]>, Alias<fno_standalone_debug>; def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Flags<[CoreOption]>, Alias<fno_standalone_debug>;
def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Flags<[CoreOption]>, Alias<fstandalone_debug>; def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Flags<[CoreOption]>, Alias<fstandalone_debug>;
▲ Show 20 Lines • Show All 1,554 Lines • Show Last 20 Lines