This is an archive of the discontinued LLVM Phabricator instance.

Differential D68573

[LoopRotate] Unconditionally get ScalarEvolution.
ClosedPublic

Authored by fhahn on Oct 7 2019, 6:07 AM.

Details

Reviewers
anemet
asbirlea
Commits
rGa70c52614363: [LoopRotate] Unconditionally get ScalarEvolution.
rL374026: [LoopRotate] Unconditionally get ScalarEvolution.
Summary

LoopRotate is a loop pass and SE should always be available.

Diff Detail

Event Timeline

fhahn created this revision.Oct 7 2019, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 6:07 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
asbirlea accepted this revision.Oct 7 2019, 1:27 PM

lgtm.

llvm/lib/Transforms/Scalar/LoopRotation.cpp
97

AFAICT this also holds true for the DominatorTreeWrapperPass.

This revision is now accepted and ready to land.Oct 7 2019, 1:27 PM
fhahn marked an inline comment as done.Oct 7 2019, 1:30 PM
fhahn added inline comments.
llvm/lib/Transforms/Scalar/LoopRotation.cpp
97

Yep. I'll commit this with both fixed.

Harbormaster completed remote builds in B39079: Diff 223540.Oct 7 2019, 10:04 PM
Closed by commit rGa70c52614363: [LoopRotate] Unconditionally get ScalarEvolution. (authored by fhahn). · Explain WhyOct 8 2019, 1:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Scalar/
5 lines

Diff 223540

llvm/lib/Transforms/Scalar/LoopRotation.cpp

Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Linespublic:
bool runOnLoop(Loop *L, LPPassManager &LPM) override { bool runOnLoop(Loop *L, LPPassManager &LPM) override {
if (skipLoop(L)) if (skipLoop(L))
return false; return false;
Function &F = *L->getHeader()->getParent(); Function &F = *L->getHeader()->getParent();
auto *LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo(); auto *LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
const auto *TTI = &getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F); const auto *TTI = &getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F);
auto *AC = &getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F); auto *AC = &getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F);
auto *DTWP = getAnalysisIfAvailable<DominatorTreeWrapperPass>(); auto *DTWP = getAnalysisIfAvailable<DominatorTreeWrapperPass>();
asbirleaUnsubmitted
Not Done
ReplyInline Actions

AFAICT this also holds true for the DominatorTreeWrapperPass.

asbirlea: AFAICT this also holds true for the DominatorTreeWrapperPass.
fhahnAuthorUnsubmitted
Done
ReplyInline Actions

Yep. I'll commit this with both fixed.

fhahn: Yep. I'll commit this with both fixed.
auto *DT = DTWP ? &DTWP->getDomTree() : nullptr; auto *DT = DTWP ? &DTWP->getDomTree() : nullptr;
auto *SEWP = getAnalysisIfAvailable<ScalarEvolutionWrapperPass>(); auto &SE = getAnalysis<ScalarEvolutionWrapperPass>().getSE();
auto *SE = SEWP ? &SEWP->getSE() : nullptr;
const SimplifyQuery SQ = getBestSimplifyQuery(*this, F); const SimplifyQuery SQ = getBestSimplifyQuery(*this, F);
Optional<MemorySSAUpdater> MSSAU; Optional<MemorySSAUpdater> MSSAU;
if (EnableMSSALoopDependency) { if (EnableMSSALoopDependency) {
MemorySSA *MSSA = &getAnalysis<MemorySSAWrapperPass>().getMSSA(); MemorySSA *MSSA = &getAnalysis<MemorySSAWrapperPass>().getMSSA();
MSSAU = MemorySSAUpdater(MSSA); MSSAU = MemorySSAUpdater(MSSA);
} }
return LoopRotation(L, LI, TTI, AC, DT, SE, return LoopRotation(L, LI, TTI, AC, DT, &SE,
MSSAU.hasValue() ? MSSAU.getPointer() : nullptr, SQ, MSSAU.hasValue() ? MSSAU.getPointer() : nullptr, SQ,
false, MaxHeaderSize, false); false, MaxHeaderSize, false);
} }
}; };
} }
char LoopRotateLegacyPass::ID = 0; char LoopRotateLegacyPass::ID = 0;
INITIALIZE_PASS_BEGIN(LoopRotateLegacyPass, "loop-rotate", "Rotate Loops", INITIALIZE_PASS_BEGIN(LoopRotateLegacyPass, "loop-rotate", "Rotate Loops",
Show All 11 Lines