This is an archive of the discontinued LLVM Phabricator instance.

[LoopRotate] Unconditionally get ScalarEvolution.
ClosedPublic

Authored by fhahn on Oct 7 2019, 6:07 AM.

Details

Diff Detail

Event Timeline

fhahn created this revision.Oct 7 2019, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 6:07 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
asbirlea accepted this revision.Oct 7 2019, 1:27 PM

lgtm.

llvm/lib/Transforms/Scalar/LoopRotation.cpp
97

AFAICT this also holds true for the DominatorTreeWrapperPass.

This revision is now accepted and ready to land.Oct 7 2019, 1:27 PM
fhahn marked an inline comment as done.Oct 7 2019, 1:30 PM
fhahn added inline comments.
llvm/lib/Transforms/Scalar/LoopRotation.cpp
97

Yep. I'll commit this with both fixed.

This revision was automatically updated to reflect the committed changes.