This is an archive of the discontinued LLVM Phabricator instance.

[Mips] Fix evaluating J-format branch targets
ClosedPublic

Authored by jrtc27 on Oct 5 2019, 5:30 PM.

Details

Summary

J/JAL/JALX/JALS are absolute branches, but stay within the current
256 MB-aligned region, so we must include the high bits of the
instruction address when calculating the branch target.

Diff Detail

Repository
rL LLVM

Event Timeline

jrtc27 created this revision.Oct 5 2019, 5:30 PM
jrtc27 updated this revision to Diff 223401.Oct 5 2019, 5:35 PM

Removed unwanted changes

atanasyan accepted this revision.Oct 7 2019, 6:57 AM

LGTM. Thanks for the patch.

This revision is now accepted and ready to land.Oct 7 2019, 6:57 AM
This revision was automatically updated to reflect the committed changes.