This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Stop using a precompiled binary in all.test
ClosedPublic

Authored by grimar on Oct 3 2019, 5:50 AM.

Details

Diff Detail

Event Timeline

grimar created this revision.Oct 3 2019, 5:50 AM
grimar edited the summary of this revision. (Show Details)Oct 3 2019, 5:50 AM
jhenderson accepted this revision.Oct 3 2019, 6:00 AM

LGTM, with one request. I think we need a GNU version of this test too, but that's probably a separate change.

You'll also want to update this test with an addrsig check at some point too.

test/tools/llvm-readobj/all.test
2–3

Would you mind making these use double dashes for --check-prefix please?

This revision is now accepted and ready to land.Oct 3 2019, 6:00 AM
grimar marked 2 inline comments as done.EditedOct 3 2019, 6:05 AM

You'll also want to update this test with an addrsig check at some point too.

Yeah, that is why I started doing this. I was under impression that no addrsig will be printed because there is no such section in a binary committed.
What I missed is that we always print something (tag name), even when there is no content to print. I am going to update the patch for addrsig.

Upd: or will just commit a minor follow-up with that.

test/tools/llvm-readobj/all.test
2–3

Sure.

This revision was automatically updated to reflect the committed changes.
grimar marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 6:15 AM