This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Stop using a precompiled binary in all.test
ClosedPublic

Authored by grimar on Oct 3 2019, 5:50 AM.

Download Raw Diff

Details

Reviewers

jhenderson
MaskRay

Commits

rG6079498c51b9: [llvm-readobj] - Stop using a precompiled binary in all.test
rL373594: [llvm-readobj] - Stop using a precompiled binary in all.test

Summary

Having a precompiled binary here is excessive.
I also added a few missing tags.

Diff Detail

Event Timeline

grimar created this revision.Oct 3 2019, 5:50 AM

Herald added subscribers: seiya, rupprecht. · View Herald TranscriptOct 3 2019, 5:50 AM

grimar edited the summary of this revision. (Show Details)Oct 3 2019, 5:50 AM

LGTM, with one request. I think we need a GNU version of this test too, but that's probably a separate change.

You'll also want to update this test with an addrsig check at some point too.

test/tools/llvm-readobj/all.test
2–3	Would you mind making these use double dashes for --check-prefix please?

This revision is now accepted and ready to land.Oct 3 2019, 6:00 AM

In D68386#1692779, @jhenderson wrote:

You'll also want to update this test with an addrsig check at some point too.

Yeah, that is why I started doing this. I was under impression that no addrsig will be printed because there is no such section in a binary committed.
What I missed is that we always print something (tag name), even when there is no content to print. I am going to update the patch for addrsig.

Upd: or will just commit a minor follow-up with that.

test/tools/llvm-readobj/all.test
2–3	Sure.

Closed by commit rL373594: [llvm-readobj] - Stop using a precompiled binary in all.test (authored by grimar). · Explain WhyOct 3 2019, 6:15 AM

This revision was automatically updated to reflect the committed changes.

grimar marked an inline comment as done.

Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 6:15 AM

Revision Contents

Path

Size

test/

tools/

llvm-readobj/

all.test

39 lines

Diff 222995

test/tools/llvm-readobj/all.test

	RUN: llvm-readobj -a %p/Inputs/trivial.obj.elf-i386 \			# RUN: yaml2obj %s -o %t.o
	RUN: \| FileCheck %s -check-prefix ALL			# RUN: llvm-readobj -a %t.o \| FileCheck %s -check-prefix ALL
	RUN: llvm-readobj --all %p/Inputs/trivial.obj.elf-i386 \			# RUN: llvm-readobj --all %t.o \| FileCheck %s -check-prefix ALL
				jhendersonUnsubmitted Done Reply Inline Actions Would you mind making these use double dashes for --check-prefix please? jhenderson: Would you mind making these use double dashes for --check-prefix please?
				grimarAuthorUnsubmitted Done Reply Inline Actions Sure. grimar: Sure.
	RUN: \| FileCheck %s -check-prefix ALL

	ALL: Format: ELF32-i386			# ALL: Format: ELF32-i386
	ALL: Arch: i386			# ALL: Arch: i386
	ALL: AddressSize: 32bit			# ALL: AddressSize: 32bit
	ALL: LoadName:			# ALL: LoadName:
	ALL: ElfHeader {			# ALL: ElfHeader {
	ALL: Sections [			# ALL: Sections [
	ALL: Relocations [			# ALL: Relocations [
	ALL: Symbols [			# ALL: Symbols [
	ALL: ProgramHeaders [			# ALL: ProgramHeaders [
	ALL: Notes [			# ALL: Version symbols {
	ALL: StackSizes [			# ALL: SHT_GNU_verdef {
				# ALL: SHT_GNU_verneed {
				# ALL: Notes [
				# ALL: StackSizes [

				--- !ELF
				FileHeader:
				Class: ELFCLASS32
				Data: ELFDATA2LSB
				Type: ET_REL
				Machine: EM_386