Having a precompiled binary here is excessive.
I also added a few missing tags.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM, with one request. I think we need a GNU version of this test too, but that's probably a separate change.
You'll also want to update this test with an addrsig check at some point too.
test/tools/llvm-readobj/all.test | ||
---|---|---|
2–3 ↗ | (On Diff #222995) | Would you mind making these use double dashes for --check-prefix please? |
Comment Actions
Yeah, that is why I started doing this. I was under impression that no addrsig will be printed because there is no such section in a binary committed.
What I missed is that we always print something (tag name), even when there is no content to print. I am going to update the patch for addrsig.
Upd: or will just commit a minor follow-up with that.
test/tools/llvm-readobj/all.test | ||
---|---|---|
2–3 ↗ | (On Diff #222995) | Sure. |