Page MenuHomePhabricator

[llvm-readobj] Replace arch-specific ObjDumper methods by the single `printArchSpecificInfo`
ClosedPublic

Authored by atanasyan on Oct 3 2019, 5:29 AM.

Details

Summary

Initially llvm-readobj supports multiple command line options like --arm-attributes and --mips-plt-got for display ELF arch-specific information. Now all these options are superseded by the --arch-specific one. It makes sense to have a single printArchSpecificInfo method in the base ObjDumper, and hide all ELF/target specific details in the ELFDumper::printArchSpecificInfo override.

Diff Detail

Repository
rL LLVM

Event Timeline

atanasyan created this revision.Oct 3 2019, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 5:29 AM

I'm fine with this change if the others have no objections.

MaskRay accepted this revision.Oct 3 2019, 7:36 PM

I'm happy with the change, which makes the scope of arch-specific features narrower.

This revision is now accepted and ready to land.Oct 3 2019, 7:36 PM
kongyi accepted this revision.Oct 3 2019, 7:55 PM
This revision was automatically updated to reflect the committed changes.