Fix: Actually erase remove the elements from AssumeHandles

[hiraditya]

Summary

remove_if only moves the elements to be erased at the end.

[hiraditya]

passed ninja check-all

[hiraditya]

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

[tejohnson]

In D68318#1691483, @hiraditya wrote:

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Does it fail without this fix?

[hiraditya]

It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll

[tejohnson]

LGTM

[hiraditya]

Splitting the verifier into a separate diff: https://reviews.llvm.org/D68345

llvm/trunk/lib/Analysis/AssumptionCache.cpp

void AssumptionCache::unregisterAssumption(CallInst *CI) {
   SmallVector<Value *, 16> Affected;
   findAffectedValues(CI, Affected);
 
   for (auto &AV : Affected) {
     auto AVI = AffectedValues.find_as(AV);
     if (AVI != AffectedValues.end())
       AffectedValues.erase(AVI);
   }
-  remove_if(AssumeHandles, [CI](WeakTrackingVH &VH) { return CI == VH; });
+
+  AssumeHandles.erase(
+      remove_if(AssumeHandles, [CI](WeakTrackingVH &VH) { return CI == VH; }),
+      AssumeHandles.end());
 }
 
 void AssumptionCache::AffectedValueCallbackVH::deleted() {
   auto AVI = AC->AffectedValues.find(getValPtr());
   if (AVI != AC->AffectedValues.end())
     AC->AffectedValues.erase(AVI);
   // 'this' now dangles!
 }