Page MenuHomePhabricator

Fix: Actually erase remove the elements from AssumeHandles
ClosedPublic

Authored by hiraditya on Oct 1 2019, 9:12 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hiraditya created this revision.Oct 1 2019, 9:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 9:12 PM
hiraditya edited the summary of this revision. (Show Details)Oct 2 2019, 8:36 AM
hiraditya added reviewers: fhahn, tejohnson.

passed ninja check-all

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Does it fail without this fix?

It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll

This revision is now accepted and ready to land.Oct 2 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.