Page MenuHomePhabricator

[JSON] Remove Utility/JSON.{h|cpp}
ClosedPublic

Authored by JDevlieghere on Oct 1 2019, 2:48 PM.

Details

Summary

This patch is the final step in my quest to get rid of the JSON parser in LLDB. Vedant's coverage report [1] shows that it was mostly untested. Furthermore, the LLVM implementation has a much nicer API and using it means one less thing to maintain for LLDB.

[1] http://lab.llvm.org:8080/coverage/coverage-reports/index.html

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Oct 1 2019, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 2:48 PM
Herald added a subscriber: mgorny. · View Herald Transcript
JDevlieghere retitled this revision from [JSON] RemoveUtility/JSON.{h|cpp} to [JSON] Remove Utility/JSON.{h|cpp}.Oct 1 2019, 2:48 PM
labath accepted this revision.Oct 2 2019, 12:42 AM

Yay. This turned to be easier than I expected.

This revision is now accepted and ready to land.Oct 2 2019, 12:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2019, 11:01 AM