Page MenuHomePhabricator

[WebAssembly] Make sure EH pads are preferred in sorting
ClosedPublic

Authored by aheejin on Sep 30 2019, 9:03 AM.

Details

Summary

In CFGSort, we try to make EH pads have higher priorities as soon as
they are ready to be sorted, to prevent creation of unwind destination
mismatches in CFGStackify. We did that by making priority queues'
comparison function prefer EH pads, but it was possible for an EH pad
to be popped from Preferred queue and then not sorted immediately and
enter Ready queue instead in a certain condition. This patch makes
sure that special condition does not consider EH pads as its candidates.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Sep 30 2019, 9:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2019, 9:03 AM
dschuff accepted this revision.Sep 30 2019, 3:40 PM
This revision is now accepted and ready to land.Sep 30 2019, 3:40 PM
This revision was automatically updated to reflect the committed changes.