When all the tests run by dotest are unsupported, it still reports RESULT: PASSED which we translate to success for lit. We can better report the status as unsupported when we see that there are unsupported tests but no passing tests. This will not affect the situation where there are failures or unexpected passes, because those report a non-zero exit code.
Details
Details
Diff Detail
Diff Detail
- Repository
- rLLDB LLDB
Event Timeline
lldb/lit/Suite/lldbtest.py | ||
---|---|---|
105 | 'UNSUPPORTED:' in out + err ? |
lldb/lit/Suite/lldbtest.py | ||
---|---|---|
105 | Is that actually faster? If not I'd like to keep things consistent with the rest of the code above and below it. |
lldb/lit/Suite/lldbtest.py | ||
---|---|---|
105 | I was optimizing for readability, not speed :-) |
lldb/lit/Suite/lldbtest.py | ||
---|---|---|
105 | I agree. It's on my todo list :-) |
'UNSUPPORTED:' in out + err ?