Page MenuHomePhabricator

[lit] Do a better job at parsing unsupported tests.
ClosedPublic

Authored by JDevlieghere on Sep 25 2019, 11:06 AM.

Details

Summary

When all the tests run by dotest are unsupported, it still reports RESULT: PASSED which we translate to success for lit. We can better report the status as unsupported when we see that there are unsupported tests but no passing tests. This will not affect the situation where there are failures or unexpected passes, because those report a non-zero exit code.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Sep 25 2019, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 11:06 AM
This revision is now accepted and ready to land.Sep 25 2019, 11:12 AM
aprantl added inline comments.Sep 25 2019, 11:14 AM
lldb/lit/Suite/lldbtest.py
105 ↗(On Diff #221806)

'UNSUPPORTED:' in out + err ?

JDevlieghere marked 2 inline comments as done.Sep 25 2019, 11:16 AM
JDevlieghere added inline comments.
lldb/lit/Suite/lldbtest.py
105 ↗(On Diff #221806)

Is that actually faster? If not I'd like to keep things consistent with the rest of the code above and below it.

aprantl added inline comments.Sep 25 2019, 12:19 PM
lldb/lit/Suite/lldbtest.py
105 ↗(On Diff #221806)

I was optimizing for readability, not speed :-)
The principled solution would be to emit the same kind of junit XML output that lit produces or some other machine-readable format.

JDevlieghere marked 3 inline comments as done.Sep 25 2019, 12:24 PM
JDevlieghere added inline comments.
lldb/lit/Suite/lldbtest.py
105 ↗(On Diff #221806)

I agree. It's on my todo list :-)

This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 12:33 PM