Page MenuHomePhabricator

[PowerPC] Extend custom lower of vector truncate to handle wider input
Needs ReviewPublic

Authored by RolandF on Sep 25 2019, 9:43 AM.

Details

Reviewers
hfinkel
Group Reviewers
Restricted Project
Summary

Current custom lowering of truncate vector handles a source of up to 128 bits, but that only uses one of the two shuffle vector operands. Extend it to use both operands to handle 256 bit sources.

Diff Detail

Event Timeline

RolandF created this revision.Sep 25 2019, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 9:43 AM

Is it possible to check the permutation mask in the test case? (I suppose that these are auto-generated tests, but the test coverage it's all that good if we can't check the mask).

RolandF updated this revision to Diff 222174.Sep 27 2019, 8:04 AM

Moved the tests to a separate file and added hand-written checks which include the permute control data.

qiucf added a subscriber: qiucf.Oct 15 2019, 1:45 AM
qiucf added inline comments.
llvm/test/CodeGen/PowerPC/vec-trunc2.ll
19

Use CHECK-COUNT?

RolandF updated this revision to Diff 225056.Oct 15 2019, 9:36 AM

Update test to use CHECK-COUNT.

RolandF marked an inline comment as done.Oct 15 2019, 9:37 AM