Page MenuHomePhabricator

[tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM
ClosedPublic

Authored by krytarowski on Sep 23 2019, 5:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Sep 23 2019, 5:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:01 AM
krytarowski added a subscriber: jakubjelinek.EditedSep 23 2019, 5:02 AM

Once GCC will grow support for __SANITIZE_LEAK__ (already pending in review) there will be included as a separate revision support for LSan/GCC.

CC: @jakubjelinek

fjricci accepted this revision.Sep 23 2019, 5:06 AM

Interesting - I had tried to add has_feature for lsan to clang in the past and couldn’t get the change accepted. Nice to see it works now :)

This revision is now accepted and ready to land.Sep 23 2019, 5:06 AM
krytarowski added a comment.EditedSep 23 2019, 5:15 AM

Interesting - I had tried to add has_feature for lsan to clang in the past and couldn’t get the change accepted. Nice to see it works now :)

We use it now in the NetBSD public headers [1] and keep __SANITIZE_LEAK__ as our local GCC extension... hopefully the GCC upstream will merge it as diverging from LLVM and from GCC downstream users.. is a cost.

[1] https://github.com/NetBSD/src/commit/e08b61780bb6fece3ba3f58a3dc6991ee831c41e

Ah okay, that makes sense

This revision was automatically updated to reflect the committed changes.