[LNT] Python 3 support: import object when inheriting from it

[thopre]

Summary

Import object from builtins for existing inheritance from object. This
was produced by running futurize's stage2 libfuturize.fixes.fix_object.

[thopre]

Ping?

[hubert.reinterpretcast]

My understanding is that this patch has no effect for Python 3. In Python 2, object from builtins (as provided by the future package) is used to enable use of some Python 3 coding patterns. Absent further changes that make use of such enablement, I am not sure that this patch is necessary. If this patch is needed to support later patches, then I suggest applying the fixer at that point. Applying the fixer before applying D67882 seems odd anyway.

[thopre]

In D67879#1697652, @hubert.reinterpretcast wrote:

My understanding is that this patch has no effect for Python 3. In Python 2, object from builtins (as provided by the future package) is used to enable use of some Python 3 coding patterns. Absent further changes that make use of such enablement, I am not sure that this patch is necessary. If this patch is needed to support later patches, then I suggest applying the fixer at that point. Applying the fixer before applying D67882 seems odd anyway.

I wholly agree (see what I wrote in D67882). And yes the ordering in which futurize do these changes is odd.

lnt/lnttool/admin.py

 #!/usr/bin/env python
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 import click
 from .common import submit_options
 
 
 def _load_dependencies():
     global yaml, sys, requests, json, os, httplib

lnt/server/db/migrations/upgrade_11_to_12.py

 # Rename 'name' field in machine parameters to 'hostname' to avoid name clash
 # in import/export file format.
+from builtins import object
 import sqlalchemy
 import json
 
 
 def update_testsuite(engine, db_key_name):
     class Machine(object):
         pass
 

lnt/server/db/migrations/upgrade_1_to_2.py

 # Version 2 didn't actually change the database schema per-se, but we changed
 # to better support versions as run orders.
 #
 # As part of this, we changed the compiler sniffing code to extract the full
 # build information from production compilers, and it was convenient to
 # propagate this change to older databases.
 #
 # So, for this upgrade, we go look for runs that used the older run_order
 # extraction, and we recompute the run order for them.
 
+from builtins import object
 import json
 import re
 
 from lnt.util import logger
 import sqlalchemy
 from sqlalchemy import Table, MetaData
 
 

lnt/server/db/testsuite.py

 """
 Database models for the TestSuites abstraction.
 """
 
 from __future__ import absolute_import
+from builtins import object
 import json
 import lnt
 from . import util
 
 import sqlalchemy
 import sqlalchemy.ext.declarative
 import sqlalchemy.orm
 from sqlalchemy import Column, Integer, ForeignKey, String, Binary, Float

lnt/server/db/testsuitedb.py

 """
 Database models for the TestSuite databases themselves.
 
 These are a bit magical because the models themselves are driven by the test
 suite metadata, so we only create the classes at runtime.
 """
 
 from __future__ import absolute_import
+from builtins import object
 import datetime
 import json
 import os
 
 import aniso8601
 import sqlalchemy
 import flask
 from sqlalchemy import Float, String, Integer, Column, ForeignKey, Binary, DateTime

lnt/server/db/v4db.py

+from builtins import object
 import glob
 import yaml
 
 try:
     import threading
 except Exception:
     import dummy_threading as threading
 

lnt/server/instance.py

+from builtins import object
 import os
 import shutil
 import tarfile
 import tempfile
 import lnt.server.config
 from lnt.util import logger
 
 

lnt/server/reporting/analysis.py

 """
 Utilities for helping with the analysis of data, for reporting purposes.
 """
 from __future__ import division
+from builtins import object
 from past.utils import old_div
 from lnt.testing import FAIL
 from lnt.util import logger
 from lnt.util import multidict
 from lnt.util import stats
 from lnt.util import stats
 
 REGRESSED = 'REGRESSED'

lnt/server/reporting/dailyreport.py

 from __future__ import division
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 from past.utils import old_div
 from lnt.server.reporting.analysis import REGRESSED, UNCHANGED_FAIL
 from lnt.server.reporting.report import RunResult, RunResults, report_css_styles, pairs, OrderAndHistory
 from lnt.util import multidict
 import datetime
 import lnt.server.reporting.analysis

lnt/server/reporting/latestrunsreport.py

+from builtins import object
 from lnt.server.reporting.analysis import REGRESSED, UNCHANGED_FAIL
 from lnt.server.reporting.report import RunResult, RunResults, report_css_styles
 import lnt.server.reporting.analysis
 import lnt.server.ui.app
 
 
 class LatestRunsReport(object):
     def __init__(self, ts, run_count):

lnt/server/reporting/summaryreport.py

 from __future__ import division
+from builtins import object
 from past.utils import old_div
 import re
 
 import lnt.testing
 import lnt.util.stats
 
 ###
 # Aggregation Function

lnt/server/ui/app.py

 from __future__ import print_function
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 import io
 import logging
 import logging.handlers
 import sys
 import time
 import traceback

lnt/server/ui/regression_views.py

+from builtins import object
 import flask
 import sqlalchemy
 import json
 from flask import g
 from flask import abort
 from flask import render_template
 from flask import request
 from flask import flash

lnt/server/ui/views.py

 from __future__ import division
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 from past.utils import old_div
 import datetime
 import json
 import os
 import re
 import time

lnt/testing/__init__.py

 """
 Utilities for working with the LNT test format.
 
 Clients can easily generate LNT test format data by creating Report
 objects for the runs they wish to submit, and using Report.render to
 convert them to JSON data suitable for submitting to the server.
 """
 
+from builtins import object
 import datetime
 import re
 from lnt.util import logger
 
 try:
     import json
 except ImportError:
     import simplejson as json

lnt/testing/profile/profile.py

+from builtins import object
 import base64
 import lnt.testing.profile
 import os
 import tempfile
 
 
 class Profile(object):
     """Profile objects hold a performance profile.

lnt/testing/profile/profilev2impl.py

 from __future__ import absolute_import
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 from .profile import ProfileImpl
 import bz2
 import copy
 import io
 import os
 import struct

lnt/testing/util/misc.py

+from builtins import object
 import datetime
 
 
 class TeeStream(object):
     """File-like object for writing to multiple output streams."""
 
     def __init__(self, a, b, noclose_b=False):
         self.a = a

lnt/testing/util/valgrind.py

 """
 Utilities for working with Valgrind.
 """
+from builtins import object
 from lnt.util import logger
 
 # See:
 #   http://valgrind.org/docs/manual/cl-format.html#cl-format.overview
 # for reference on the calltree data format specification.
 
 
 class CalltreeParseError(Exception):

lnt/tests/builtintest.py

 """
 Base class for builtin-in tests.
 """
 
 from __future__ import print_function
+from builtins import object
 import sys
 import os
 
 from lnt.testing.util.misc import timestamp
 
 import lnt.util.ServerUtil as ServerUtil
 import lnt.util.ImportData as ImportData
 

lnt/tests/nt.py

 """LLVM test-suite compile and execution tests"""
 from __future__ import absolute_import
 from __future__ import print_function
+from builtins import object
 from future import standard_library
 standard_library.install_aliases()
 import csv
 import os
 import platform
 import re
 import shutil
 import subprocess

tests/SharedInputs/FakeCompilers/fakecompiler.py

 #!/usr/bin/env python
 
 """
 Utilities for "faking" a compiler response.
 """
 from __future__ import print_function
 
+from builtins import object
 import inspect
 import os
 import sys
 
 g_program = None
 
 
 class FakeCompiler(object):