This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Use LLVM_FALLTHROUGH instead of a custom comment
ClosedPublic

Authored by mstorsjo on Sep 20 2019, 1:39 PM.

Reviewers

Commits

Summary

This fixes a warning when built with Clang instead of MSVC.

This revision is now accepted and ready to land.Sep 20 2019, 2:13 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

source/

Plugins/

Process/

Windows/

Common/

2 lines

Show First 20 Lines • Show All 473 Lines • ▼ Show 20 Lines	if (!initial_stop) {
// the program hasn't returned from Factory::Launch() and the delegate		// the program hasn't returned from Factory::Launch() and the delegate
// might not have an valid native process to operate on.		// might not have an valid native process to operate on.
SetState(eStateStopped, false);		SetState(eStateStopped, false);

// Hit the initial stop. Continue the application.		// Hit the initial stop. Continue the application.
return ExceptionResult::BreakInDebugger;		return ExceptionResult::BreakInDebugger;
}		}

// Fall through		LLVM_FALLTHROUGH;
default:		default:
LLDB_LOG(log,		LLDB_LOG(log,
"Debugger thread reported exception {0:x} at address {1:x} "		"Debugger thread reported exception {0:x} at address {1:x} "
"(first_chance={2})",		"(first_chance={2})",
record.GetExceptionCode(), record.GetExceptionAddress(),		record.GetExceptionCode(), record.GetExceptionAddress(),
first_chance);		first_chance);

{		{
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines