This is an archive of the discontinued LLVM Phabricator instance.

Differential D67859

[LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC
ClosedPublic

Authored by mstorsjo on Sep 20 2019, 1:34 PM.

Details

Reviewers
hhb
labath
amccarth
compnerd
Commits
rG8969f8d11ea7: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC
rLLDB372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC
rL372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 20 2019, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 1:34 PM
Herald added a subscriber: JDevlieghere. · View Herald Transcript
mstorsjo added a reviewer: compnerd.Sep 21 2019, 11:01 AM
labath accepted this revision.Sep 23 2019, 2:36 AM
This revision is now accepted and ready to land.Sep 23 2019, 2:36 AM
Closed by commit rL372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC (authored by mstorsjo). · Explain WhySep 23 2019, 5:02 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:02 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
trunk/
include/
lldb/
Host/
2 lines

Diff 221292

lldb/trunk/include/lldb/Host/Socket.h

Show All 25 Lines
#endif #endif
namespace llvm { namespace llvm {
class StringRef; class StringRef;
} }
namespace lldb_private { namespace lldb_private {
#if defined(_MSC_VER) #if defined(_WIN32)
typedef SOCKET NativeSocket; typedef SOCKET NativeSocket;
#else #else
typedef int NativeSocket; typedef int NativeSocket;
#endif #endif
class Socket : public IOObject { class Socket : public IOObject {
public: public:
enum SocketProtocol { enum SocketProtocol {
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines