This is an archive of the discontinued LLVM Phabricator instance.

Differential D67857

[LLDB] Include lldb/Host/windows/windows.h on any windows target
AbandonedPublic

Authored by mstorsjo on Sep 20 2019, 1:16 PM.

Details

Reviewers
lanza
hhb
labath
compnerd
Summary

This fixes MinGW builds, that otherwise fail due to use of undeclared GetLastError() and ERROR_OPERATION_ABORTED.

The use of GetLastError() was added in SVN r366520 (within an #ifdef _WIN32), while the existing include of lldb/Host/windows/windows.h was within #ifdef _MSC_VER. Change the include ifdef to #ifdef _WIN32.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 20 2019, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 1:16 PM
Herald added subscribers: JDevlieghere, abidh. · View Herald Transcript
mstorsjo added a reviewer: compnerd.Sep 21 2019, 11:01 AM
mstorsjo abandoned this revision.Sep 22 2019, 11:07 AM
mstorsjo mentioned this in D67887: Use _WIN32 instead of _MSC_VER.

D67887 was committed with the same change.

Revision Contents

PathSize
lldb/
source/
Core/
2 lines

Diff 221099

lldb/source/Core/IOHandler.cpp

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
#include "lldb/Target/StopInfo.h" #include "lldb/Target/StopInfo.h"
#include "lldb/Target/Target.h" #include "lldb/Target/Target.h"
#include "lldb/Target/Thread.h" #include "lldb/Target/Thread.h"
#include "lldb/Utility/State.h" #include "lldb/Utility/State.h"
#endif #endif
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#ifdef _MSC_VER #ifdef _WIN32
#include "lldb/Host/windows/windows.h" #include "lldb/Host/windows/windows.h"
#endif #endif
#include <memory> #include <memory>
#include <mutex> #include <mutex>
#include <assert.h> #include <assert.h>
#include <ctype.h> #include <ctype.h>
▲ Show 20 Lines • Show All 991 Lines • Show Last 20 Lines