[LLDB] Fix compilation for MinGW, remove redundant class name on inline member

[mstorsjo]

Summary

This fixes build errors like these:

NativeRegisterContextWindows.h:22:33: error: extra qualification on member 'NativeRegisterContextWindows'
  NativeRegisterContextWindows::NativeRegisterContextWindows(
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

[davide]

If this doesn't break clang and gcc, fine.

[mstorsjo]

In D67856#1677356, @davide wrote:

If this doesn't break clang and gcc, fine.

FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc.

But the issue can be tested with a snippet like this:

class Foo {
public: 
        Foo::Foo() {}
};

With MSVC, this passes fine without any warnings. With clang-cl (or plain clang with an msvc target), it builds but warns (-Wmicrosoft-extra-qualification), with gcc it's an error (that can be waived with -fpermissive), and with clang a non-msvc target, it's an unrecoverable error.

[davide]

Just keep an eye on the bots as they might start whining
http://green.lab.llvm.org/green/

otherwise, just go ahead.

lldb/trunk/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h

 #include "lldb/Utility/DataBufferHeap.h"
 
 namespace lldb_private {
 
 class NativeThreadWindows;
 
 class NativeRegisterContextWindows : public NativeRegisterContextRegisterInfo {
 public:
-  NativeRegisterContextWindows::NativeRegisterContextWindows(
+  NativeRegisterContextWindows(
       NativeThreadProtocol &native_thread,
       RegisterInfoInterface *reg_info_interface_p);
 
   static std::unique_ptr<NativeRegisterContextWindows>
   CreateHostNativeRegisterContextWindows(const ArchSpec &target_arch,
                                          NativeThreadProtocol &native_thread);
 
 protected:
   lldb::thread_t GetThreadHandle() const;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_NativeRegisterContextWindows_h_