- Should consider viable ones only when checking SameSide candidates.
- Replace erasing with clearing viable flag to reduce data moving/copying.
- Add one and revise another one as the diagnostic message are more relevant compared to previous one.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 38272 Build 38271: arc lint + arc unit
Event Timeline
Comment Actions
LGTM. You may want to wait a bit for Justin's feedback, in case he has some concerns.
clang/test/SemaCUDA/function-overload.cu | ||
---|---|---|
406 | I'd remove irrelevant. | |
407–411 | We don't need definitions for struct and operator-; This should do: struct C1; struct C2; __device__ int operator-(const C1 &x, const C1 &y); int operator-(const C2 &x, const C2 &y); ... int test_constexpr_overload(C2 &x, C2 &y) { return constexpr_overload(x, y); } | |
414 | Is constexpr necessary here? If not, then we would not need -std=c++11 either. |
I'd remove irrelevant.