Page MenuHomePhabricator

[llvm-objcopy] - Remove python invocations from 2 test cases.
ClosedPublic

Authored by grimar on Sep 16 2019, 2:46 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Sep 16 2019, 2:46 AM
jhenderson accepted this revision.Sep 16 2019, 2:55 AM

LGTM, with one possible suggestion.

test/tools/llvm-objcopy/ELF/overlapping-sections-in-segments.test
7 ↗(On Diff #220298)

I don't mind if you want to keep it, but you can probably just get rid of the sanity check now. Now it is just a check that yaml2obj works as expected.

test/tools/llvm-objcopy/ELF/overlapping-sections.test
6 ↗(On Diff #220298)

Ditto.

This revision is now accepted and ready to land.Sep 16 2019, 2:55 AM
grimar marked an inline comment as done.Sep 16 2019, 3:01 AM
grimar added inline comments.
test/tools/llvm-objcopy/ELF/overlapping-sections-in-segments.test
7 ↗(On Diff #220298)

Yeah, I thought about that too. I had no strong feeling. I'll remove then.

MaskRay accepted this revision.Sep 16 2019, 3:17 AM
jakehehrlich accepted this revision.Sep 16 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2019, 1:37 AM