Page MenuHomePhabricator

[PowerPC] [NFC] refactor PPCLoopPreIncPrep pass for further ds/dq form usage.
ClosedPublic

Authored by shchenz on Sep 10 2019, 10:00 PM.

Details

Summary

This is first part of patch https://reviews.llvm.org/D67088.

In that patch, we want to extend PPCLoopPreIncPrep pass for DS/DQ form for loads/stores with same base.

This is a NFC patch.

Diff Detail

Repository
rL LLVM

Event Timeline

shchenz created this revision.Sep 10 2019, 10:00 PM
jsji accepted this revision as: jsji.Sep 24 2019, 11:28 AM

Looks mostly good to me , except for some nit formatting issues and comments.

llvm/lib/Target/PowerPC/PPCLoopPreIncPrep.cpp
121 ↗(On Diff #220662)

extra space before \p.

142 ↗(On Diff #220662)

typo: preparation.

284 ↗(On Diff #220662)

Can we add TODO: or FIXME in beginning instead of Need to improve this at the end.

487 ↗(On Diff #220662)

clang-formatted? why extra space in last two lines?

524 ↗(On Diff #220662)

Is this clang-formatted? Format looks weird to me here.

564 ↗(On Diff #220662)

Some comments before this lamda please.

This revision is now accepted and ready to land.Sep 24 2019, 11:28 AM
shchenz updated this revision to Diff 221660.Sep 24 2019, 7:55 PM

address @jsji comments

shchenz marked 6 inline comments as done.Sep 24 2019, 7:58 PM

Thanks for your time @jsji

llvm/lib/Target/PowerPC/PPCLoopPreIncPrep.cpp
487 ↗(On Diff #220662)

i should not change this function. It is wrongly shown by diff tool. Anyway, I change it since it is a obvious format issue.

This revision was automatically updated to reflect the committed changes.