This is an archive of the discontinued LLVM Phabricator instance.

Differential D67394

[NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF
AbandonedPublic

Authored by gchatelet on Sep 10 2019, 5:55 AM.

Details

Reviewers
rnk
Summary

When rebasing on Linux git would convert llvm/test/MC/AsmParser/preserve-comments-crlf.s to Line Feed End Of Lines.
This property ensures that the file always stays CRLF on checkout

Diff Detail

Event Timeline

gchatelet created this revision.Sep 10 2019, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2019, 5:55 AM
Herald added subscribers: llvm-commits, dexonsmith. · View Herald Transcript
Harbormaster completed remote builds in B37955: Diff 219530.Sep 10 2019, 5:55 AM
gchatelet added a reviewer: courbet.Sep 10 2019, 5:56 AM
gchatelet added a reviewer: rnk.Sep 10 2019, 8:10 AM
gchatelet removed reviewers: jfb, courbet.
gchatelet added a subscriber: courbet.
rnk accepted this revision.Sep 10 2019, 10:29 AM

I see that llvm/.gitattributes already exists, and I assumed that was enough, but I see that it is not. lgtm

This revision is now accepted and ready to land.Sep 10 2019, 10:29 AM
rnk requested changes to this revision.Sep 10 2019, 10:36 AM

Hm, see rL371513. I'm not sure what the correct fix is.

This revision now requires changes to proceed.Sep 10 2019, 10:36 AM
gchatelet abandoned this revision.Sep 11 2019, 12:42 AM

Yes rL371513 is the way to go. Thx for the review, I'll abandon this patch.

Revision Contents

PathSize
1 line

Diff 219530

.gitattributes

  • This file was added.
llvm/test/MC/AsmParser/preserve-comments-crlf.s text eol=crlf