Page MenuHomePhabricator

[NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF
AbandonedPublic

Authored by gchatelet on Tue, Sep 10, 5:55 AM.

Details

Reviewers
rnk
Summary

When rebasing on Linux git would convert llvm/test/MC/AsmParser/preserve-comments-crlf.s to Line Feed End Of Lines.
This property ensures that the file always stays CRLF on checkout

Event Timeline

gchatelet created this revision.Tue, Sep 10, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 10, 5:55 AM
gchatelet removed reviewers: jfb, courbet.
gchatelet added a subscriber: courbet.
rnk accepted this revision.Tue, Sep 10, 10:29 AM

I see that llvm/.gitattributes already exists, and I assumed that was enough, but I see that it is not. lgtm

This revision is now accepted and ready to land.Tue, Sep 10, 10:29 AM
rnk requested changes to this revision.Tue, Sep 10, 10:36 AM

Hm, see rL371513. I'm not sure what the correct fix is.

This revision now requires changes to proceed.Tue, Sep 10, 10:36 AM
gchatelet abandoned this revision.Wed, Sep 11, 12:42 AM

Yes rL371513 is the way to go. Thx for the review, I'll abandon this patch.