Page MenuHomePhabricator

[COFF] Fix to not add archive name to buffer identifiers when they come from thin archives.
ClosedPublic

Authored by akhuang on Sep 6 2019, 11:13 AM.

Details

Summary

Currently lld adds the archive name to MemoryBufferRef identifiers in order to
ensure they are unique. For thin archives, since the file name is already unique and we
want to keep the original path to the file, don't add the archive name.

Diff Detail

Repository
rL LLVM

Event Timeline

akhuang created this revision.Sep 6 2019, 11:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2019, 11:13 AM
rnk added a comment.Sep 6 2019, 4:10 PM

Looks right to me, but let's wait for @inlgorion to take a look on Monday.

inglorion accepted this revision.Sep 12 2019, 1:04 PM

lgtm, thanks!

This revision is now accepted and ready to land.Sep 12 2019, 1:04 PM
This revision was automatically updated to reflect the committed changes.